Skip to content

Adds clusters for the in place upgrades tests #3990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2024
Merged

Adds clusters for the in place upgrades tests #3990

merged 2 commits into from
Sep 20, 2024

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Sep 20, 2024

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Adds GKE Autopilot and GKE Standard test cluster for use in the In Place Upgrades tests. The clusters follow the same pattern as the existing e2e test clusters. The Upgrades standard cluster do not require as much compute as the e2e clusters, so the initial node count is lower than for the e2e tests.

Which issue(s) this PR fixes:

Working on #3795

Special notes for your reviewer:

@igooch igooch requested a review from gongmax September 20, 2024 16:15
@github-actions github-actions bot added kind/feature New features for Agones size/S labels Sep 20, 2024
gongmax
gongmax reviewed Sep 20, 2024
View reviewed changes
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 538ab5e6-e27d-4fe0-9c3f-8ee2e2efa909

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3990/head:pr_3990 && git checkout pr_3990
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-29a2f78

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 78153012-8886-468c-9284-2d11706aaa7d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3990/head:pr_3990 && git checkout pr_3990
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-591a49f

gongmax
gongmax approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@gongmax gongmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. We can do some refactoring to reduce the redundant code used for both e2e and upgrade as a follow up.

@gongmax gongmax merged commit 77face1 into googleforgames:main Sep 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gongmax gongmax gongmax approved these changes

Assignees
No one assigned
Labels
kind/feature New features for Agones size/M size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igooch @agones-bot @gongmax