Skip to content

Use Markdown when use k8s-api-version variable #3964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 9, 2024
Merged

Use Markdown when use k8s-api-version variable #3964

merged 3 commits into from
Sep 9, 2024

Conversation

peterzhongyi
Copy link
Collaborator

@peterzhongyi peterzhongyi commented Aug 23, 2024 •
edited
Loading

#3962 was submitted to fix the broken CI: https://pantheon.corp.google.com/cloud-build/builds;region=global/ee067e2c-418a-4be3-869e-1cdc31a777fc;step=19?e=13803378&mods=allow_workbench_image_override&project=agones-images

Later #3963 was submitted to use k8s-api-version using string literal.

This PR achieves the same effect as #3963 with Markdown syntax since the files are .md files.

@peterzhongyi peterzhongyi changed the title why does this not work Use Markdown when use k8s-api-version variable Aug 23, 2024
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 1a6ecc13-45d3-403f-8937-7b197374d2db

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3964/head:pr_3964 && git checkout pr_3964
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-b4973d4

igooch
igooch approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Making a note that this style is in keeping with the rest of the site documentation.

@igooch igooch enabled auto-merge (squash) September 9, 2024 04:10
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 37d24e44-782f-469f-ae91-9f111c83b72f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3964/head:pr_3964 && git checkout pr_3964
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-9ea2840

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 69971681-3030-41db-b716-9cec8634845a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3964/head:pr_3964 && git checkout pr_3964
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-d154f52

@igooch igooch merged commit 5e4dbca into googleforgames:main Sep 9, 2024
4 checks passed
@peterzhongyi peterzhongyi mentioned this pull request Oct 1, 2024
Closed
5 tasks
@kamaljeeti kamaljeeti added kind/cleanup Refactoring code, fixing up documentation, etc and removed kind/other labels Oct 3, 2024
@peterzhongyi peterzhongyi deleted the doc branch November 26, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igooch igooch igooch approved these changes

Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peterzhongyi @agones-bot @igooch @kamaljeeti