Skip to content

Adds schedule and chain policy to fleetautoscaler documentation #3934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 1, 2024
Merged

Adds schedule and chain policy to fleetautoscaler documentation #3934

merged 8 commits into from
Sep 1, 2024

Conversation

indexjoseph
Copy link
Contributor

@indexjoseph indexjoseph commented Aug 7, 2024 •
edited
Loading

What type of PR is this?

/kind documentation

What this PR does / Why we need it:

Adds schedule/chain policy to the fleetautoscaler documentation on the agones site

Which issue(s) this PR fixes:

Towards #3008

Special notes for your reviewer:

@github-actions github-actions bot added kind/documentation Documentation for Agones size/M labels Aug 7, 2024
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: a313ec6f-19ee-46f0-b2aa-6e1c89209f7e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3934/head:pr_3934 && git checkout pr_3934
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-b7df38d

@indexjoseph indexjoseph marked this pull request as ready for review August 7, 2024 22:58
vicentefb
vicentefb reviewed Aug 8, 2024
View reviewed changes
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 3b8258e4-b1e9-4ef4-b1a4-765522c11650

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3934/head:pr_3934 && git checkout pr_3934
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-2033343

igooch
igooch reviewed Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few nits.

igooch
igooch approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igooch igooch enabled auto-merge (squash) August 26, 2024 19:08
@igooch igooch disabled auto-merge August 26, 2024 19:09
@igooch
Copy link
Collaborator

igooch commented Aug 26, 2024

We'll wait until after the release tomorrow to merge.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: f0b91324-542c-4505-94a1-c4e6faadfe7e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3934/head:pr_3934 && git checkout pr_3934
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-0bed969

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 0285152f-2f40-4296-aff7-40371c562217

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3934/head:pr_3934 && git checkout pr_3934
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-9541bc6

@igooch igooch enabled auto-merge (squash) August 29, 2024 22:37
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: c8380607-9077-4988-9e9a-a1cf99889d1f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3934/head:pr_3934 && git checkout pr_3934
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-eb229e6

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: de53e3a3-dbd2-4864-bffb-5799f3baa6f5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3934/head:pr_3934 && git checkout pr_3934
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-ddb351e

@igooch igooch merged commit 655e340 into googleforgames:main Sep 1, 2024
4 checks passed
@vicentefb vicentefb mentioned this pull request Oct 15, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicentefb vicentefb vicentefb left review comments

@igooch igooch igooch approved these changes

Assignees
No one assigned
Labels
kind/documentation Documentation for Agones size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@indexjoseph @agones-bot @igooch @vicentefb