Skip to content

Conversation

ashutosji
Copy link
Contributor

@ashutosji ashutosji commented Jul 9, 2024

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:#3892, #3903, #3901

Closes #3892, #3903, #3901

Special notes for your reviewer:

@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/S labels Jul 9, 2024
@ashutosji ashutosji requested review from igooch and markmandel July 9, 2024 11:28
@ashutosji
Copy link
Contributor Author

ashutosji commented Jul 9, 2024

The make cloud-build command has succeeded for all the necessary example images in my project and i have pushed all those images in my artifact registry.
The go.mod and go.sum files need not to be updated as this is a patch version update.

Once, this build succeed please let me know if i can push these images on prod. I will update these new images link to everywhere.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 40f2ed55-16c2-4841-8d4b-5b4e6a6d59f8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3894/head:pr_3894 && git checkout pr_3894
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-1b52e62-amd64

@ashutosji
Copy link
Contributor Author

My bad, I could have created this PR as a draft.

@igooch igooch changed the title update go version to 1.21.2 update go version to 1.21.12 Jul 9, 2024
Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the original issue to include the steps from the golang_version_upgrade template. It looks like there's a couple files that will need to be updated. If you run through the steps in the issue that will resolve the few outstanding items. Otherwise looks good!

    modified:   examples/allocation-endpoint/server/Dockerfile
    modified:   go.mod
    modified:   site/go.mod
    modified:   site/go.sum

@ashutosji
Copy link
Contributor Author

I updated the original issue to include the steps from the golang_version_upgrade template. It looks like there's a couple files that will need to be updated. If you run through the steps in the issue that will resolve the few outstanding items. Otherwise looks good!

    modified:   examples/allocation-endpoint/server/Dockerfile
    modified:   go.mod
    modified:   site/go.mod
    modified:   site/go.sum

Thank you so much for your guidance!
The absence of relevant images in the prod will cause this PR to fail.

As we already tested this with a previous commit, everything works perfectly with my own images. Allow me to push these images to prod.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: fb47c1a4-005e-4775-b0c7-5014c75c94d8

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@ashutosji ashutosji force-pushed the update-go-version branch from fcba4e3 to 88d05eb Compare July 14, 2024 06:59
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: cd3ff9e5-afa6-4071-a6bd-49c2da997d8e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3894/head:pr_3894 && git checkout pr_3894
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-88d05eb-amd64

Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igooch igooch merged commit 74e8d74 into googleforgames:main Jul 15, 2024
spiceratops referenced this pull request in spiceratops/k8s-gitops Jul 23, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [agones](https://agones.dev)
([source](https://togithub.com/googleforgames/agones)) | minor |
`1.41.0` -> `1.42.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>googleforgames/agones (agones)</summary>

###
[`v1.42.0`](https://togithub.com/googleforgames/agones/blob/HEAD/CHANGELOG.md#v1420-2024-07-16)

[Compare
Source](https://togithub.com/googleforgames/agones/compare/v1.41.0...v1.42.0)

[Full
Changelog](https://togithub.com/googleforgames/agones/compare/v1.41.0...v1.42.0)

**Breaking changes:**

- Update csharp.md to indicate ConnectAsync is deprecated by
[@&#8203;aallbrig](https://togithub.com/aallbrig) in
[https://github.com/googleforgames/agones/pull/3866](https://togithub.com/googleforgames/agones/pull/3866)

**Implemented enhancements:**

- Add security context to Agones containers by
[@&#8203;peterzhongyi](https://togithub.com/peterzhongyi) in
[https://github.com/googleforgames/agones/pull/3856](https://togithub.com/googleforgames/agones/pull/3856)
- Add Security Context to game server sidecar by
[@&#8203;peterzhongyi](https://togithub.com/peterzhongyi) in
[https://github.com/googleforgames/agones/pull/3869](https://togithub.com/googleforgames/agones/pull/3869)
- Drop CountsAndLists Data from the Fleet and Game Server Set When the
Flag is False by [@&#8203;igooch](https://togithub.com/igooch) in
[https://github.com/googleforgames/agones/pull/3881](https://togithub.com/googleforgames/agones/pull/3881)
- Adds tests to confirm that Fleet, Fleet Autoscaler, and Fleet
Allocation apply defaults code is idempotent by
[@&#8203;igooch](https://togithub.com/igooch) in
[https://github.com/googleforgames/agones/pull/3888](https://togithub.com/googleforgames/agones/pull/3888)
- feat: Add CRD Changes and Feature Flag for chain policy by
[@&#8203;indexjoseph](https://togithub.com/indexjoseph) in
[https://github.com/googleforgames/agones/pull/3880](https://togithub.com/googleforgames/agones/pull/3880)

**Fixed bugs:**

- sdk-server expects SDK_LOG_LEVEL by
[@&#8203;KAllan357](https://togithub.com/KAllan357) in
[https://github.com/googleforgames/agones/pull/3858](https://togithub.com/googleforgames/agones/pull/3858)
- this will resolve From/layer extraction issue on ltsc2019 in examples
by [@&#8203;ashutosji](https://togithub.com/ashutosji) in
[https://github.com/googleforgames/agones/pull/3873](https://togithub.com/googleforgames/agones/pull/3873)
- featuregate: adds validation if PortPolicyNone is not enabled by
[@&#8203;daniellee](https://togithub.com/daniellee) in
[https://github.com/googleforgames/agones/pull/3871](https://togithub.com/googleforgames/agones/pull/3871)
- added local as default for registry when registry is not specified by
[@&#8203;kamaljeeti](https://togithub.com/kamaljeeti) in
[https://github.com/googleforgames/agones/pull/3876](https://togithub.com/googleforgames/agones/pull/3876)
- Buffer Unity SDK ReceiveData when watching for configuration changes
by [@&#8203;ZeroParticle](https://togithub.com/ZeroParticle) in
[https://github.com/googleforgames/agones/pull/3872](https://togithub.com/googleforgames/agones/pull/3872)
- agones-{extensions,allocator}: Make servers context aware by
[@&#8203;zmerlynn](https://togithub.com/zmerlynn) in
[https://github.com/googleforgames/agones/pull/3845](https://togithub.com/googleforgames/agones/pull/3845)
- added condition for distributed logic by
[@&#8203;ashutosji](https://togithub.com/ashutosji) in
[https://github.com/googleforgames/agones/pull/3877](https://togithub.com/googleforgames/agones/pull/3877)

**Security fixes:**

- Bump [@&#8203;grpc/grpc-js](https://togithub.com/grpc/grpc-js) from
1.10.7 to 1.10.9 in /sdks/nodejs by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/googleforgames/agones/pull/3863](https://togithub.com/googleforgames/agones/pull/3863)

**Other:**

- Preparation for Release v1.42.0 by
[@&#8203;ashutosji](https://togithub.com/ashutosji) in
[https://github.com/googleforgames/agones/pull/3854](https://togithub.com/googleforgames/agones/pull/3854)
- Add helpful note to edit-first-gameserver-go by
[@&#8203;peterzhongyi](https://togithub.com/peterzhongyi) in
[https://github.com/googleforgames/agones/pull/3846](https://togithub.com/googleforgames/agones/pull/3846)
- Moved Passthrough feature description to the correct section in
Feature Stages by [@&#8203;vicentefb](https://togithub.com/vicentefb) in
[https://github.com/googleforgames/agones/pull/3861](https://togithub.com/googleforgames/agones/pull/3861)
- Updated Node.js Page to Reflect that Counters and Lists is Implemented
by [@&#8203;ashutosji](https://togithub.com/ashutosji) in
[https://github.com/googleforgames/agones/pull/3865](https://togithub.com/googleforgames/agones/pull/3865)
- Change Slack channel description from #developers to #development by
[@&#8203;branhoff](https://togithub.com/branhoff) in
[https://github.com/googleforgames/agones/pull/3868](https://togithub.com/googleforgames/agones/pull/3868)
- updated UpdateList documentation for local sdk server and sdk server
by [@&#8203;ashutosji](https://togithub.com/ashutosji) in
[https://github.com/googleforgames/agones/pull/3878](https://togithub.com/googleforgames/agones/pull/3878)
- Add zio-agones to the list of third party client SDKs by
[@&#8203;ghostdogpr](https://togithub.com/ghostdogpr) in
[https://github.com/googleforgames/agones/pull/3875](https://togithub.com/googleforgames/agones/pull/3875)
- refactor simple game server by
[@&#8203;ashutosji](https://togithub.com/ashutosji) in
[https://github.com/googleforgames/agones/pull/3817](https://togithub.com/googleforgames/agones/pull/3817)
- Update Slack invite link by
[@&#8203;markmandel](https://togithub.com/markmandel) in
[https://github.com/googleforgames/agones/pull/3896](https://togithub.com/googleforgames/agones/pull/3896)
- Added cleanup for app-engine services in cloudbuild script by
[@&#8203;kamaljeeti](https://togithub.com/kamaljeeti) in
[https://github.com/googleforgames/agones/pull/3890](https://togithub.com/googleforgames/agones/pull/3890)
- Adds a command to generate the zz_generated.deepcopy.go files for the
apis by [@&#8203;igooch](https://togithub.com/igooch) in
[https://github.com/googleforgames/agones/pull/3900](https://togithub.com/googleforgames/agones/pull/3900)
- update go version to 1.21.12 by
[@&#8203;ashutosji](https://togithub.com/ashutosji) in
[https://github.com/googleforgames/agones/pull/3894](https://togithub.com/googleforgames/agones/pull/3894)

**New Contributors:**

- [@&#8203;KAllan357](https://togithub.com/KAllan357) made their first
contribution in
[https://github.com/googleforgames/agones/pull/3858](https://togithub.com/googleforgames/agones/pull/3858)
- [@&#8203;branhoff](https://togithub.com/branhoff) made their first
contribution in
[https://github.com/googleforgames/agones/pull/3868](https://togithub.com/googleforgames/agones/pull/3868)
- [@&#8203;aallbrig](https://togithub.com/aallbrig) made their first
contribution in
[https://github.com/googleforgames/agones/pull/3866](https://togithub.com/googleforgames/agones/pull/3866)
- [@&#8203;ZeroParticle](https://togithub.com/ZeroParticle) made their
first contribution in
[https://github.com/googleforgames/agones/pull/3872](https://togithub.com/googleforgames/agones/pull/3872)
- [@&#8203;ghostdogpr](https://togithub.com/ghostdogpr) made their first
contribution in
[https://github.com/googleforgames/agones/pull/3875](https://togithub.com/googleforgames/agones/pull/3875)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/M size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Golang Version to 1.21.12
3 participants