Skip to content

Conversation

denizsurmeli
Copy link

What this PR does / Why we need it:
This PR fixes the naming error in testing/e2e/in_memory.go.
Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@google-cla
Copy link

google-cla bot commented Aug 10, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@denizsurmeli denizsurmeli marked this pull request as draft August 10, 2023 09:14
@denizsurmeli denizsurmeli marked this pull request as ready for review August 10, 2023 09:14
@denizsurmeli
Copy link
Author

Can you please rerun the actions ? I have signed the CLA.

Copy link
Collaborator

@joeholley joeholley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will add to v1.8 milestone as it requires some manual intervention.

@joeholley
Copy link
Collaborator

tracking note: manually merged in builddebug branch commit a5e789c

@joeholley joeholley closed this Aug 16, 2023
@joeholley joeholley mentioned this pull request Aug 17, 2023
@joeholley joeholley mentioned this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants