Skip to content

Conversation

mridulji
Copy link
Contributor

What this PR does / Why we need it: This PR modifies the FrontendService.WatchAssignment function and listens to the ctx.Done functionality of GRPC stream in callback function so that in every retry of callback function, it is checked whether the user has terminated this API call or not.

Which issue(s) this PR fixes:

Closes #1472

Special notes for your reviewer:

  • Updated the GKE version for regular channel support (i.e. 1.22.8-gke.202) Reference

Copy link
Contributor

@syntxerror syntxerror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@syntxerror syntxerror merged commit a9d122f into googleforgames:main Jul 18, 2022
@mridulji mridulji added this to the v1.5.0 milestone Aug 16, 2022
@mridulji mridulji added enhancement New feature or request good first issue Good for newcomers labels Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/refinement enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusion in the codes of WatchAssignments function
2 participants