Skip to content

Add custom annotations to Service Account #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sierrasoleil
Copy link
Contributor

What this PR does / Why we need it:
This PR adds the ability to include custom annotations on the Open Match service account. My specific use case is to allow that service account to leverage Workload Identity to write logs and metrics.

@google-cla
Copy link

google-cla bot commented Jun 27, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sierrasoleil sierrasoleil force-pushed the service-account-annotations branch from caaa010 to f3b3b42 Compare June 27, 2022 17:04
@mridulji
Copy link
Contributor

mridulji commented Aug 5, 2022

Hey @sierrasoleil, Could you please file an issue using applicable template to elaborate the problem faced and/or what solutions you suggest to it and mention that issue in this PR so that it will be helpful for community to understand it.

@mridulji
Copy link
Contributor

@sierrasoleil, May I know if you are still working on it and would like to re-iterate that it would be very helpful if you file an issue explaining the problem.

@sierrasoleil
Copy link
Contributor Author

@mridulji I submitted issue 1485 to explain the change.

Copy link
Contributor

@syntxerror syntxerror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@syntxerror syntxerror merged commit a9f985d into googleforgames:main Aug 23, 2022
@mridulji mridulji added this to the v1.5.0 milestone Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants