Skip to content

update to google.golang.org/protobuf and deprecation changes #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jan 17, 2023
Merged

update to google.golang.org/protobuf and deprecation changes #1444

merged 20 commits into from
Jan 17, 2023

Conversation

mridulji
Copy link
Contributor

@mridulji mridulji commented Mar 4, 2022 •
edited
Loading

What this PR does / Why we need it:
Update package github.com/golang/protobuf to google.golang.org/protobuf to keep Open Match dependencies up-to-date.

Which issue(s) this PR fixes:

Closes #1443

Special notes for your reviewer:
Tools updates:
protoc v3.19.4
kubectl v1.21.5
golang v1.19.4

@mridulji mridulji added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2022
@mridulji mridulji force-pushed the update_golang_protobuf branch from 5c3ea8c to 60f4b3e Compare July 27, 2022 18:25
@mridulji mridulji requested a review from andrewgrundy July 29, 2022 14:30
@syntxerror syntxerror mentioned this pull request Nov 1, 2022
Closed
@castaneai
Copy link

@andrewgrundy Hi, I am trying to start developing open-match but need to upgrade toolchains for building on Apple Silicon (arm64) machine. I look forward to your review!

@mridulji mridulji force-pushed the update_golang_protobuf branch from 45141ae to cf9bd0e Compare November 14, 2022 12:19
@mridulji mridulji marked this pull request as draft November 22, 2022 11:42
@mridulji mridulji force-pushed the update_golang_protobuf branch from e485a32 to bfae0d1 Compare December 13, 2022 16:08
@mridulji mridulji force-pushed the update_golang_protobuf branch from d0f076c to 6e8454d Compare December 14, 2022 10:26
@mridulji mridulji force-pushed the update_golang_protobuf branch 3 times, most recently from 53f57ce to df6e036 Compare January 13, 2023 18:57
@mridulji mridulji marked this pull request as ready for review January 17, 2023 15:21
@mridulji mridulji requested a review from amg84 as a code owner January 17, 2023 15:21
@mridulji
Copy link
Contributor Author

Some snapshots of open-match, demo in action after making golang upgradation changes in this PR. Works well with mm101-tutorial.

image
image
image

@syntxerror syntxerror removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2023
syntxerror
syntxerror approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@syntxerror syntxerror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@syntxerror syntxerror merged commit 67be350 into googleforgames:main Jan 17, 2023
@syntxerror syntxerror removed the request for review from andrewgrundy January 17, 2023 18:59
@mridulji mridulji added this to the v1.7.0 milestone Feb 10, 2023
@mridulji mridulji added good first issue Good for newcomers area/feature area/productionization dependencies Pull requests that update a dependency file labels Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aLekSer aLekSer Awaiting requested review from aLekSer aLekSer is a code owner

@HazWard HazWard Awaiting requested review from HazWard

@calebatwd calebatwd Awaiting requested review from calebatwd calebatwd is a code owner

@sawagh sawagh Awaiting requested review from sawagh

@scosgrave scosgrave Awaiting requested review from scosgrave scosgrave is a code owner

@amg84 amg84 Awaiting requested review from amg84 amg84 is a code owner

2 more reviewers

@syntxerror syntxerror syntxerror approved these changes

@andrewgrundy andrewgrundy andrewgrundy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/feature area/productionization dependencies Pull requests that update a dependency file good first issue Good for newcomers
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

github.com/golang/protobuf has been deprecated. Moved to google.golang.org/protobuf
4 participants
@mridulji @castaneai @syntxerror @andrewgrundy