AssignTickets empty check and test cases added #1438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBBle
reviewed
Feb 8, 2022
| @@ -255,6 +255,10 @@ func (rb *redisBackend) UpdateAssignments(ctx context.Context, req *pb.AssignTic | |||
| } | |||
| } | |||
|
|
|||
| if len(idsI) == 0 { | |||
| return nil, nil, status.Error(codes.InvalidArgument, "AssignmentGroupTicketIds is empty") | |||
There was a problem hiding this comment.
Isn't this test only going to match if all AssignmentGroups had empty TicketIds? It would be clearer if the message referred to that, as the closest I can see to AssignmentGroupTicketIds would be AssignmentGroup.TicketIds which would be an error appropriate for any AssignmentGroups having empty TicketIds.
There was a problem hiding this comment.
since variable idsI contains all TicketIds so this check will prevent from throwing error when there is not a single TicketIds is present and if any AssignmentGroups having empty TicketIds will be silently ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it: When making a call to
AssignTicketsRequest, To check at least one of theAssignmentGrouphave at least oneticket_idspresent such that redis command doesn't throw error.To prevent the code execution from going into this situation, we can check the length of the array containing all
ticket_ids, so that in caseAssignmentGroupdoesn't contain any value inticket_idswill return errorcodes.InvalidArgumentWhich issue(s) this PR fixes: #1266
Closes #
Special notes for your reviewer:
unit test case condition added:
TestUpdateAssignmentse2e test case added:
TestAssignTicketsEmpty