Skip to content

docker build optimization by using mount cache for go dependencies #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

mridulji
Copy link
Contributor

What this PR does / Why we need it:
Reduces docker CMD build times by mounting cache for go dependencies.

Which issue(s) this PR fixes:
#1227

Closes #

Special notes for your reviewer:

It requires docker 19.03 version or later which is not very much new (released on 2019-07-22) and latest verision is 20.10 so I hope it works for all.

https://www.docker.com/blog/containerize-your-go-developer-environment-part-1/#:~:text=As%20we%20are,in%20your%20environment.

Reference :- https://www.docker.com/blog/containerize-your-go-developer-environment-part-2/

Copy link
Contributor

@syntxerror syntxerror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@syntxerror syntxerror merged commit 47c3458 into googleforgames:main Jan 26, 2022
@mridulji mridulji added this to the v1.4.0 milestone Mar 14, 2022
@mridulji mridulji added the enhancement New feature or request label Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants