Skip to content

fix outdated apiVersion in frontend scale testing helm template #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2021
Merged

fix outdated apiVersion in frontend scale testing helm template #1419

merged 1 commit into from
Sep 22, 2021

Conversation

joeholley
Copy link
Collaborator

What this PR does / Why we need it:
Recent k8s APIs remove Deployment from extensions/v1beta1, it's now in apps/v1.

Which issue(s) this PR fixes:
Without this update, yaml generated by this template fails with
no matches for kind "Deployment" in version "extensions/v1beta1"

@joeholley
fix outdate apiVersion
db4f409 
Recent k8s APIs remove Deployment from extensions/v1beta1, it's now in apps/v1
@google-cla google-cla bot added the cla: yes label Sep 16, 2021
@joeholley joeholley changed the title fix outdate apiVersion fix outdated apiVersion Sep 16, 2021
@joeholley joeholley changed the title fix outdated apiVersion fix outdated apiVersion in frontend scale testing helm template Sep 16, 2021
@syntxerror syntxerror merged commit 2e03c1a into googleforgames:main Sep 22, 2021
@joeholley joeholley deleted the patch-1 branch December 6, 2021 08:00
@mridulji mridulji added this to the v1.4.0 milestone Mar 14, 2022
@mridulji mridulji added the breaking api change Breaking API change that may require migration for existing customers to update to new version. label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aLekSer aLekSer Awaiting requested review from aLekSer aLekSer is a code owner

@calebatwd calebatwd Awaiting requested review from calebatwd calebatwd is a code owner

@HazWard HazWard Awaiting requested review from HazWard

@sawagh sawagh Awaiting requested review from sawagh

@syntxerror syntxerror Awaiting requested review from syntxerror

1 more reviewer

@andrewgrundy andrewgrundy andrewgrundy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
breaking api change Breaking API change that may require migration for existing customers to update to new version. cla: yes
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@joeholley @andrewgrundy @syntxerror @mridulji