Skip to content

The previous tag name does not respect custom tagSeparator and/or includeVInTag: false in the generated PR #2282

@niieani

Description

@niieani

PR with a fix: #2283

Environment details

  • OS: macOS 14.4.1 (23E224)
  • Node.js version: v21.1.0
  • npm version: 10.7.0
  • release-please version: 16.10.2

Steps to reproduce

  1. set a custom, e.g. tagSeparator: "@" and/or includeVInTag: false
  2. run release-please release-pr from CLI (or via the Github Action)

The created PR will generate the following URL for each version of a release:

https://github.com/org/package/compare/package-v1.0.0...package@1.0.1
                                       ^^^^^^^^^^^^^^

As you can see:

  • the 1st tag name is incorrect: package-v1.0.1 - does not respect neither tagSeparator nor includeVInTag setting
  • the 2nd tag name is correct: package@1.0.1 - respects tagSeparator: "@" and includeVInTag: false
See screenshot Screenshot 2024-05-04 at 19 31 33

Metadata

Metadata

Assignees

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions