You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In our tracing update reviews, everyone initially raised the need to record a span event whenever a new mutation had been added and I spun up some pull requests. However, @harshachinta wisely noted that if a customer creates 40,000 mutations to be added before invoking .commit(), 40,000 separate events would be created hence this would constitute a horrible user experience and also lots of data that a customer could be charged for spans per https://github.com/googleapis/python-spanner/pull/1259/files#r1875359721
Facts
by default, 128 span events is the maximum per span: it can be controlled by environment configuration with OpenTelemetry
this isn't a show stopper and can be thought about and added so much later on once there is consensus
there is recording of num_mutations when invoking .commit() that I had added as a span attribute per