Skip to content

chore: Skip archived test #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 8, 2024
Merged

chore: Skip archived test #2018

merged 9 commits into from
Mar 8, 2024

Conversation

surbhigarg92
Copy link
Contributor

No description provided.

@surbhigarg92 surbhigarg92 requested review from a team as code owners March 8, 2024 06:44
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Mar 8, 2024
@surbhigarg92 surbhigarg92 changed the title Skip archived test chore: Skip archived test Mar 8, 2024
@surbhigarg92 surbhigarg92 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 8, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 8, 2024
harshachinta
harshachinta approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@harshachinta harshachinta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can we make sure we have a plan to run these archived samples in some way? We could otherwise not detect issues with those samples.
Few thoughts on doing this,

  1. Run the archived samples in continuous and nightly builds thus leaving out presubmits.
  2. Run active and archived samples in presubmit only when there are changes in samples directory.

There could be some other better strategy but having this would help us find any regressions in archived samples.

@surbhigarg92 surbhigarg92 removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 8, 2024
@generated-files-bot Generated Files Bot
Copy link

Warning: This pull request is touching the following templated files:

  • .kokoro/samples-test.sh - .kokoro files are templated and should be updated in synthtool

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Mar 8, 2024
@surbhigarg92 surbhigarg92 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 8, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 8, 2024
@surbhigarg92
Copy link
Contributor Author

LGTM, but can we make sure we have a plan to run these archived samples in some way? We could otherwise not detect issues with those samples. Few thoughts on doing this,

  1. Run the archived samples in continuous and nightly builds thus leaving out presubmits.
  2. Run active and archived samples in presubmit only when there are changes in samples directory.

There could be some other better strategy but having this would help us find any regressions in archived samples.

Added the change to make sure we are running archived tests in continuous and nightly builds

@surbhigarg92 surbhigarg92 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 8, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 8, 2024
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Mar 8, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit fc99d8e into googleapis:main Mar 8, 2024
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshachinta harshachinta harshachinta approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@surbhigarg92 @harshachinta