-
Notifications
You must be signed in to change notification settings - Fork 110
Closed
Labels
api: spannerIssues related to the googleapis/nodejs-spanner API.Issues related to the googleapis/nodejs-spanner API.priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Description
This issue serves as a decision marker and record for our method of attack to get observability in for this package. I implemented
2 kinds of tracing to ensure the team had a buffet of options:
- manual tracing per PR DO NOT MERGE: feat: instrument src/ with traces using OpenTelemetry #2087 complete with tests and end-to-end working samples and docs
- auto-instrumentation with traceWrapping per PR tracing: update OpenTelemetry dependencies from 2021 to 2024 python-spanner#1199 complete with tests and end-to-end working samples and docs
Internally at Google it was discussed and resolved with @surbhigarg92 representing us when tabled with the OpenTelemetry team at Google that:
- traceWrap was well received but we should send that instrumentation to be hosted at opentelemetry-js-contrib
- manually instrument the libraries currently
One thing to note is that we shall need to add feature guards that will ensure that customers don't doubly import the future opentelemetry-instrumentation-spanner and then also with the manual spans.
Metadata
Metadata
Assignees
Labels
api: spannerIssues related to the googleapis/nodejs-spanner API.Issues related to the googleapis/nodejs-spanner API.priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.