Skip to content

observability: use manual tracing instead of auto-traceWrapping until opentelemetry-instrumentation-spanner is ported #2114

@odeke-em

Description

@odeke-em

This issue serves as a decision marker and record for our method of attack to get observability in for this package. I implemented
2 kinds of tracing to ensure the team had a buffet of options:

Internally at Google it was discussed and resolved with @surbhigarg92 representing us when tabled with the OpenTelemetry team at Google that:

  • traceWrap was well received but we should send that instrumentation to be hosted at opentelemetry-js-contrib
  • manually instrument the libraries currently

One thing to note is that we shall need to add feature guards that will ensure that customers don't doubly import the future opentelemetry-instrumentation-spanner and then also with the manual spans.

Metadata

Metadata

Assignees

No one assigned

    Labels

    api: spannerIssues related to the googleapis/nodejs-spanner API.priority: p3Desirable enhancement or fix. May not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions