fix: Improve performance of the UTF-8 string comparison logic #2380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes the UTF-8 string comparison logic to improve performance and simplify the algorithm. It achieves this by directly comparing UTF-16 code units and handling surrogate pairs appropriately. The changes result in faster string comparisons without sacrificing correctness, with the added benefit of a simpler and more readable algorithm.
Highlights
The semantics of the UTF-8 string comparison logic were originally fixed by #2275, but this fix caused a material performance degradation, which was then improved by #2299 The performance was, however, still suboptimal, and this PR further improves the speed back to close to its original speed and, serendipitously, simplifies the algorithm too.
This commit is a port of firebase/firebase-js-sdk#9143