Skip to content

fix: Add the deprecation notice for tracing enable/disable option. #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix: Add the deprecation notice for tracing enable/disable option. #1866

merged 1 commit into from
Oct 17, 2024

Conversation

ehsannas
Copy link
Contributor

@ehsannas ehsannas commented Oct 3, 2024

No description provided.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Oct 3, 2024
@ehsannas ehsannas self-assigned this Oct 3, 2024
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/java-firestore API. label Oct 3, 2024
@ehsannas ehsannas marked this pull request as ready for review October 3, 2024 22:05
@ehsannas ehsannas requested review from a team as code owners October 3, 2024 22:05
@ehsannas ehsannas force-pushed the ehsann/deprecate-tracing-enable-flag branch from 495c756 to f41cf4d Compare October 4, 2024 22:05
@ehsannas ehsannas requested a review from milaGGL October 10, 2024 20:03
milaGGL
milaGGL approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehsannas ehsannas merged commit d213245 into main Oct 17, 2024
24 checks passed
@ehsannas ehsannas deleted the ehsann/deprecate-tracing-enable-flag branch October 17, 2024 21:03
@release-please release-please bot mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milaGGL milaGGL milaGGL approved these changes

Assignees

@ehsannas ehsannas

@milaGGL milaGGL

Labels
api: firestore Issues related to the googleapis/java-firestore API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehsannas @milaGGL