Skip to content

Conversation

diegomarquezp
Copy link
Contributor

The current errorprone version is not compatible with JDK 24 onwards. While we dont have a long term solution, we will disable the check for JDK 24.

The current errorprone version is not compatible with JDK 24 onwards.
While we dont have a long term solution, we will disable the check for JDK 24.
@diegomarquezp diegomarquezp requested review from a team as code owners June 11, 2025 19:54
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: datastore Issues related to the googleapis/java-datastore API. labels Jun 11, 2025
@cindy-peng cindy-peng merged commit fe7f8a0 into main Jun 12, 2025
24 checks passed
@cindy-peng cindy-peng deleted the disable-errorprone-jdk-24 branch June 12, 2025 17:18
@diegomarquezp
Copy link
Contributor Author

error_prone-core is not managed by sdk-platform-java. It is unique to java-datastore.

We need a long term solution. Two options would be

  • upgrade errorprone core to the latest (which supports JDK 17+ only) and drop the check for Java 8 and 11.
  • Keep this fix as is until the Cloud SDK drops support for JDK 8 and 11

cc: @cindy-peng @blakeli0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the googleapis/java-datastore API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants