fix: #419 TLS https URL for SSE endpoint #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, didn't seem to help after rebuild of this in a new image and redeploy it still seems to return http. |
|
One of my colleagues said Hey 🙂 by not working do you mean that the if If so I've seen something like this before in the past in environments with TLS termination - |
|
Works now |
|
/gcbrun |
Yuan325
approved these changes
Apr 9, 2025
annguy3n
pushed a commit
to annguy3n/genai-toolbox
that referenced
this pull request
Apr 10, 2025
Fixes that in SSL deployments, e.g. on k8s or cloud run the SSE endpoint was statically returning `http:` not a scheme based on request TLS attribute. Fixes googleapis#419 --------- Co-authored-by: Yuan <45984206+Yuan325@users.noreply.github.com>
duwenxin99
added a commit
that referenced
this pull request
Apr 23, 2025
🤖 I have created a release *beep* *boop* --- ## [0.4.0](v0.3.0...v0.4.0) (2025-04-23) ### Features * Add `AuthRequired` to Neo4j & Dgraph Tools ([#434](#434)) ([afbf4b2](afbf4b2)) * Add `AuthRequired` to tool manifest ([#433](#433)) ([d9388ad](d9388ad)) * Add BigQuery source and tool ([#463](#463)) ([8055aa5](8055aa5)) * Add Bigtable source and tool ([#418](#418)) ([ae53b8e](ae53b8e)) * Add IAM AuthN to AlloyDB Source ([#399](#399)) ([e8ed447](e8ed447)) * Add IAM AuthN to Cloud SQL Sources ([#414](#414)) ([be85b82](be85b82)) * Add toolset feature to mcp ([#425](#425)) ([e307857](e307857)), closes [#403](#403) * Add SQLite source and tool ([#438](#438)) ([fc14cbf](fc14cbf)) * Support env replacement for tools.yaml ([#462](#462)) ([eadb678](eadb678)) ### Bug Fixes * [#419](#419) TLS https URL for SSE endpoint ([#420](#420)) ([0a7d3ff](0a7d3ff)) * **docs:** Fix link 'Edit this page' ([#454](#454)) ([969065e](969065e)), closes [#427](#427) * Update http error code from invocation ([#468](#468)) ([ff7c0ff](ff7c0ff)), closes [#465](#465) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com> Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Apr 23, 2025
🤖 I have created a release *beep* *boop* --- ## [0.4.0](v0.3.0...v0.4.0) (2025-04-23) ### Features * Add `AuthRequired` to Neo4j & Dgraph Tools ([#434](#434)) ([afbf4b2](afbf4b2)) * Add `AuthRequired` to tool manifest ([#433](#433)) ([d9388ad](d9388ad)) * Add BigQuery source and tool ([#463](#463)) ([8055aa5](8055aa5)) * Add Bigtable source and tool ([#418](#418)) ([ae53b8e](ae53b8e)) * Add IAM AuthN to AlloyDB Source ([#399](#399)) ([e8ed447](e8ed447)) * Add IAM AuthN to Cloud SQL Sources ([#414](#414)) ([be85b82](be85b82)) * Add toolset feature to mcp ([#425](#425)) ([e307857](e307857)), closes [#403](#403) * Add SQLite source and tool ([#438](#438)) ([fc14cbf](fc14cbf)) * Support env replacement for tools.yaml ([#462](#462)) ([eadb678](eadb678)) ### Bug Fixes * [#419](#419) TLS https URL for SSE endpoint ([#420](#420)) ([0a7d3ff](0a7d3ff)) * **docs:** Fix link 'Edit this page' ([#454](#454)) ([969065e](969065e)), closes [#427](#427) * Update http error code from invocation ([#468](#468)) ([ff7c0ff](ff7c0ff)), closes [#465](#465) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com> Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com> 4ed16cc
github-actions bot
pushed a commit
to renovate-bot/googleapis-_-genai-toolbox
that referenced
this pull request
Apr 23, 2025
🤖 I have created a release *beep* *boop* --- ## [0.4.0](googleapis/genai-toolbox@v0.3.0...v0.4.0) (2025-04-23) ### Features * Add `AuthRequired` to Neo4j & Dgraph Tools ([googleapis#434](googleapis#434)) ([afbf4b2](googleapis@afbf4b2)) * Add `AuthRequired` to tool manifest ([googleapis#433](googleapis#433)) ([d9388ad](googleapis@d9388ad)) * Add BigQuery source and tool ([googleapis#463](googleapis#463)) ([8055aa5](googleapis@8055aa5)) * Add Bigtable source and tool ([googleapis#418](googleapis#418)) ([ae53b8e](googleapis@ae53b8e)) * Add IAM AuthN to AlloyDB Source ([googleapis#399](googleapis#399)) ([e8ed447](googleapis@e8ed447)) * Add IAM AuthN to Cloud SQL Sources ([googleapis#414](googleapis#414)) ([be85b82](googleapis@be85b82)) * Add toolset feature to mcp ([googleapis#425](googleapis#425)) ([e307857](googleapis@e307857)), closes [googleapis#403](googleapis#403) * Add SQLite source and tool ([googleapis#438](googleapis#438)) ([fc14cbf](googleapis@fc14cbf)) * Support env replacement for tools.yaml ([googleapis#462](googleapis#462)) ([eadb678](googleapis@eadb678)) ### Bug Fixes * [googleapis#419](googleapis#419) TLS https URL for SSE endpoint ([googleapis#420](googleapis#420)) ([0a7d3ff](googleapis@0a7d3ff)) * **docs:** Fix link 'Edit this page' ([googleapis#454](googleapis#454)) ([969065e](googleapis@969065e)), closes [googleapis#427](googleapis#427) * Update http error code from invocation ([googleapis#468](googleapis#468)) ([ff7c0ff](googleapis@ff7c0ff)), closes [googleapis#465](googleapis#465) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com> Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com> 4ed16cc
jeffreyrubi
pushed a commit
to jeffreyrubi/genai-toolbox
that referenced
this pull request
Jun 7, 2025
Fixes that in SSL deployments, e.g. on k8s or cloud run the SSE endpoint was statically returning `http:` not a scheme based on request TLS attribute. Fixes googleapis#419 --------- Co-authored-by: Yuan <45984206+Yuan325@users.noreply.github.com>
jeffreyrubi
pushed a commit
to jeffreyrubi/genai-toolbox
that referenced
this pull request
Jun 7, 2025
🤖 I have created a release *beep* *boop* --- ## [0.4.0](googleapis/genai-toolbox@v0.3.0...v0.4.0) (2025-04-23) ### Features * Add `AuthRequired` to Neo4j & Dgraph Tools ([googleapis#434](googleapis#434)) ([afbf4b2](googleapis@afbf4b2)) * Add `AuthRequired` to tool manifest ([googleapis#433](googleapis#433)) ([d9388ad](googleapis@d9388ad)) * Add BigQuery source and tool ([googleapis#463](googleapis#463)) ([8055aa5](googleapis@8055aa5)) * Add Bigtable source and tool ([googleapis#418](googleapis#418)) ([ae53b8e](googleapis@ae53b8e)) * Add IAM AuthN to AlloyDB Source ([googleapis#399](googleapis#399)) ([e8ed447](googleapis@e8ed447)) * Add IAM AuthN to Cloud SQL Sources ([googleapis#414](googleapis#414)) ([be85b82](googleapis@be85b82)) * Add toolset feature to mcp ([googleapis#425](googleapis#425)) ([e307857](googleapis@e307857)), closes [googleapis#403](googleapis#403) * Add SQLite source and tool ([googleapis#438](googleapis#438)) ([fc14cbf](googleapis@fc14cbf)) * Support env replacement for tools.yaml ([googleapis#462](googleapis#462)) ([eadb678](googleapis@eadb678)) ### Bug Fixes * [googleapis#419](googleapis#419) TLS https URL for SSE endpoint ([googleapis#420](googleapis#420)) ([0a7d3ff](googleapis@0a7d3ff)) * **docs:** Fix link 'Edit this page' ([googleapis#454](googleapis#454)) ([969065e](googleapis@969065e)), closes [googleapis#427](googleapis#427) * Update http error code from invocation ([googleapis#468](googleapis#468)) ([ff7c0ff](googleapis@ff7c0ff)), closes [googleapis#465](googleapis#465) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com> Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that in SSL deployments, e.g. on k8s or cloud run the SSE endpoint was statically returning
http:not a scheme based on request TLS attribute.
Fixes #419