Skip to content

Conversation

duwenxin99
Copy link
Contributor

@duwenxin99 duwenxin99 commented Apr 21, 2025

Environment variable replacement is needed so that users don't have to hardcode their secrets in configuring tools.yaml.
Both formats $ENV_NAME and ${ENV_NAME} are standard ways to declare an environment variable.
However, some database statement placeholders that are already using the $ENV_NAME format.
Therefore, we only support env var declaration using ${ENV_NAME} to disambiguate it from other usages.

Fixes issue: #431

@duwenxin99 duwenxin99 requested a review from a team as a code owner April 21, 2025 21:20
@duwenxin99 duwenxin99 requested a review from kurtisvg April 21, 2025 21:34
Copy link
Contributor

Copy link
Collaborator

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we need to add some documentation for this. Maybe in configuration for tools.yaml?

Copy link
Contributor

1 similar comment
Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

@duwenxin99 duwenxin99 merged commit eadb678 into main Apr 23, 2025
7 checks passed
@duwenxin99 duwenxin99 deleted the secret branch April 23, 2025 11:33
Copy link
Contributor

🧨 Preview deployments removed.

github-actions bot pushed a commit that referenced this pull request Apr 23, 2025
Environment variable replacement is needed so that users don't have to
hardcode their secrets in configuring `tools.yaml`.
Both formats `$ENV_NAME` and `${ENV_NAME}` are standard ways to declare
an environment variable.
However, some database statement placeholders that are already using the
`$ENV_NAME` format.
Therefore, we only support env var declaration using `${ENV_NAME}` to
disambiguate it from other usages.

Fixes issue: #431 eadb678
github-actions bot pushed a commit to renovate-bot/googleapis-_-genai-toolbox that referenced this pull request Apr 23, 2025
Environment variable replacement is needed so that users don't have to
hardcode their secrets in configuring `tools.yaml`.
Both formats `$ENV_NAME` and `${ENV_NAME}` are standard ways to declare
an environment variable.
However, some database statement placeholders that are already using the
`$ENV_NAME` format.
Therefore, we only support env var declaration using `${ENV_NAME}` to
disambiguate it from other usages.

Fixes issue: googleapis#431 eadb678
duwenxin99 added a commit that referenced this pull request Apr 23, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.4.0](v0.3.0...v0.4.0)
(2025-04-23)


### Features

* Add `AuthRequired` to Neo4j & Dgraph Tools
([#434](#434))
([afbf4b2](afbf4b2))
* Add `AuthRequired` to tool manifest
([#433](#433))
([d9388ad](d9388ad))
* Add BigQuery source and tool
([#463](#463))
([8055aa5](8055aa5))
* Add Bigtable source and tool
([#418](#418))
([ae53b8e](ae53b8e))
* Add IAM AuthN to AlloyDB Source
([#399](#399))
([e8ed447](e8ed447))
* Add IAM AuthN to Cloud SQL Sources
([#414](#414))
([be85b82](be85b82))
* Add toolset feature to mcp
([#425](#425))
([e307857](e307857)),
closes [#403](#403)
* Add SQLite source and tool
([#438](#438))
([fc14cbf](fc14cbf))
* Support env replacement for tools.yaml
([#462](#462))
([eadb678](eadb678))


### Bug Fixes

* [#419](#419) TLS
https URL for SSE endpoint
([#420](#420))
([0a7d3ff](0a7d3ff))
* **docs:** Fix link 'Edit this page'
([#454](#454))
([969065e](969065e)),
closes [#427](#427)
* Update http error code from invocation
([#468](#468))
([ff7c0ff](ff7c0ff)),
closes [#465](#465)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com>
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Apr 23, 2025
🤖 I have created a release *beep* *boop*
---

##
[0.4.0](v0.3.0...v0.4.0)
(2025-04-23)

### Features

* Add `AuthRequired` to Neo4j & Dgraph Tools
([#434](#434))
([afbf4b2](afbf4b2))
* Add `AuthRequired` to tool manifest
([#433](#433))
([d9388ad](d9388ad))
* Add BigQuery source and tool
([#463](#463))
([8055aa5](8055aa5))
* Add Bigtable source and tool
([#418](#418))
([ae53b8e](ae53b8e))
* Add IAM AuthN to AlloyDB Source
([#399](#399))
([e8ed447](e8ed447))
* Add IAM AuthN to Cloud SQL Sources
([#414](#414))
([be85b82](be85b82))
* Add toolset feature to mcp
([#425](#425))
([e307857](e307857)),
closes [#403](#403)
* Add SQLite source and tool
([#438](#438))
([fc14cbf](fc14cbf))
* Support env replacement for tools.yaml
([#462](#462))
([eadb678](eadb678))

### Bug Fixes

* [#419](#419) TLS
https URL for SSE endpoint
([#420](#420))
([0a7d3ff](0a7d3ff))
* **docs:** Fix link 'Edit this page'
([#454](#454))
([969065e](969065e)),
closes [#427](#427)
* Update http error code from invocation
([#468](#468))
([ff7c0ff](ff7c0ff)),
closes [#465](#465)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com>
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com> 4ed16cc
github-actions bot pushed a commit to renovate-bot/googleapis-_-genai-toolbox that referenced this pull request Apr 23, 2025
🤖 I have created a release *beep* *boop*
---

##
[0.4.0](googleapis/genai-toolbox@v0.3.0...v0.4.0)
(2025-04-23)

### Features

* Add `AuthRequired` to Neo4j & Dgraph Tools
([googleapis#434](googleapis#434))
([afbf4b2](googleapis@afbf4b2))
* Add `AuthRequired` to tool manifest
([googleapis#433](googleapis#433))
([d9388ad](googleapis@d9388ad))
* Add BigQuery source and tool
([googleapis#463](googleapis#463))
([8055aa5](googleapis@8055aa5))
* Add Bigtable source and tool
([googleapis#418](googleapis#418))
([ae53b8e](googleapis@ae53b8e))
* Add IAM AuthN to AlloyDB Source
([googleapis#399](googleapis#399))
([e8ed447](googleapis@e8ed447))
* Add IAM AuthN to Cloud SQL Sources
([googleapis#414](googleapis#414))
([be85b82](googleapis@be85b82))
* Add toolset feature to mcp
([googleapis#425](googleapis#425))
([e307857](googleapis@e307857)),
closes [googleapis#403](googleapis#403)
* Add SQLite source and tool
([googleapis#438](googleapis#438))
([fc14cbf](googleapis@fc14cbf))
* Support env replacement for tools.yaml
([googleapis#462](googleapis#462))
([eadb678](googleapis@eadb678))

### Bug Fixes

* [googleapis#419](googleapis#419) TLS
https URL for SSE endpoint
([googleapis#420](googleapis#420))
([0a7d3ff](googleapis@0a7d3ff))
* **docs:** Fix link 'Edit this page'
([googleapis#454](googleapis#454))
([969065e](googleapis@969065e)),
closes [googleapis#427](googleapis#427)
* Update http error code from invocation
([googleapis#468](googleapis#468))
([ff7c0ff](googleapis@ff7c0ff)),
closes [googleapis#465](googleapis#465)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com>
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com> 4ed16cc
jeffreyrubi pushed a commit to jeffreyrubi/genai-toolbox that referenced this pull request Jun 7, 2025
Environment variable replacement is needed so that users don't have to
hardcode their secrets in configuring `tools.yaml`.
Both formats `$ENV_NAME` and `${ENV_NAME}` are standard ways to declare
an environment variable.
However, some database statement placeholders that are already using the
`$ENV_NAME` format.
Therefore, we only support env var declaration using `${ENV_NAME}` to
disambiguate it from other usages.

Fixes issue: googleapis#431
jeffreyrubi pushed a commit to jeffreyrubi/genai-toolbox that referenced this pull request Jun 7, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.4.0](googleapis/genai-toolbox@v0.3.0...v0.4.0)
(2025-04-23)


### Features

* Add `AuthRequired` to Neo4j & Dgraph Tools
([googleapis#434](googleapis#434))
([afbf4b2](googleapis@afbf4b2))
* Add `AuthRequired` to tool manifest
([googleapis#433](googleapis#433))
([d9388ad](googleapis@d9388ad))
* Add BigQuery source and tool
([googleapis#463](googleapis#463))
([8055aa5](googleapis@8055aa5))
* Add Bigtable source and tool
([googleapis#418](googleapis#418))
([ae53b8e](googleapis@ae53b8e))
* Add IAM AuthN to AlloyDB Source
([googleapis#399](googleapis#399))
([e8ed447](googleapis@e8ed447))
* Add IAM AuthN to Cloud SQL Sources
([googleapis#414](googleapis#414))
([be85b82](googleapis@be85b82))
* Add toolset feature to mcp
([googleapis#425](googleapis#425))
([e307857](googleapis@e307857)),
closes [googleapis#403](googleapis#403)
* Add SQLite source and tool
([googleapis#438](googleapis#438))
([fc14cbf](googleapis@fc14cbf))
* Support env replacement for tools.yaml
([googleapis#462](googleapis#462))
([eadb678](googleapis@eadb678))


### Bug Fixes

* [googleapis#419](googleapis#419) TLS
https URL for SSE endpoint
([googleapis#420](googleapis#420))
([0a7d3ff](googleapis@0a7d3ff))
* **docs:** Fix link 'Edit this page'
([googleapis#454](googleapis#454))
([969065e](googleapis@969065e)),
closes [googleapis#427](googleapis#427)
* Update http error code from invocation
([googleapis#468](googleapis#468))
([ff7c0ff](googleapis@ff7c0ff)),
closes [googleapis#465](googleapis#465)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com>
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants