chore(v2): merge x-goog-api-client vals into a single header #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quartzmo
reviewed
Jun 13, 2024
| mergedXgoogHeader.WriteString(v) | ||
| mergedXgoogHeader.WriteRune(' ') | ||
| } | ||
| } | ||
| } | ||
| for i := 0; i < len(keyvals); i = i + 2 { | ||
| out[keyvals[i]] = append(out[keyvals[i]], keyvals[i+1]) |
There was a problem hiding this comment.
Did you want to skip setting this for the x-goog-api-client header? Maybe move this line below the if block below, and add a continue statement to the end of the if block? This is not necessary due to the overwrite on line 196, but might seem cleaner.
There was a problem hiding this comment.
Makes sense, I'll change that.
quartzmo
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.