Adding check (in datastore) that setup.py README is valid RST. #3316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My rationale is:
|
51b7b03 to
ec98ae7
Compare
|
OK @lukesneeringer PTAL |
theacodes
approved these changes
Apr 19, 2017
lukesneeringer
approved these changes
Apr 20, 2017
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Apr 20, 2017
Follow up to googleapis#3316. Fixes googleapis#2246.
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Apr 20, 2017
Follow up to googleapis#3316. Fixes googleapis#2446.
dhermes
added a commit
that referenced
this pull request
Apr 20, 2017
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…s#3318) * Adding check that **all** setup.py README's are valid RST. Follow up to googleapis#3316. Fixes googleapis#2446. * Fixing duplicate reference in Logging README. * Fixing duplicate reference in Monitoring README.
atulep
pushed a commit
that referenced
this pull request
Apr 3, 2023
atulep
pushed a commit
that referenced
this pull request
Apr 18, 2023
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
parthea
pushed a commit
that referenced
this pull request
Jul 6, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @jonparrott
@lukesneeringer You mentioned that you'd prefer a standalone session for this. I am unclear why you prefer this. To me, checking that the
READMEisn't invalid insetup.pyis linting.