Add 'Bucket.list_notifications' API wrapper. #3990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
dhermes
reviewed
Sep 18, 2017
| @@ -405,6 +424,30 @@ def list_blobs(self, max_results=None, page_token=None, prefix=None, | |||
| iterator.prefixes = set() | |||
| return iterator | |||
|
|
|||
| def list_notifications(self, client=None): | |||
| """List pubsub notifications for this bucket. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| :returns: the new notification instance | ||
| :raises ValueError: | ||
| if resource is missing 'topic' key, or if it is not formatted | ||
| per documented spec. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| match = _TOPIC_REF_RE.match(topic_path) | ||
| if match is None: | ||
| raise ValueError( | ||
| 'Resource has invalid topic: {}'.format(topic_path)) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@dhermes Any remaining issues? |
tseaver
added a commit
that referenced
this pull request
Sep 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses #3983 as a base.
Toward #3956.