Making base connection module non-public and making connection attribute non-public #2703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e008e6b to
e06d1d3
Compare
In particular: bigquery, bigtable and datastore. (The only change in bigtable was an import, and that attribute should probably go elsewhere.)
In particular: dns, language, logging, monitoring. Transitively, error reporting has also been covered (by logging).
In particular: pubsub/resource_manager/runtimeconfig/speech/translate.
In particular: storage/vision.
Also fixing a merge issue with new datastore Iterator.
e06d1d3 to
523d751
Compare
|
@tseaver PTAL? |
|
Hmm, I thought we'd approved this already. |
|
You're probably thinking about #2690. Shall I merge then? |
|
Yes. |
This was referenced Nov 14, 2016
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Nov 14, 2016
Rename happened as part of googleapis#2703 (this changeset predates that PR, but googleapis#2703 is already merged).
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Making base connection module non-public and making connection attribute non-public
atulep
pushed a commit
that referenced
this pull request
Apr 3, 2023
Making base connection module non-public and making connection attribute non-public
atulep
pushed a commit
that referenced
this pull request
Apr 18, 2023
Making base connection module non-public and making connection attribute non-public
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
Making base connection module non-public and making connection attribute non-public
parthea
pushed a commit
that referenced
this pull request
Jul 6, 2023
Making base connection module non-public and making connection attribute non-public
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
Making base connection module non-public and making connection attribute non-public
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
Making base connection module non-public and making connection attribute non-public
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
Making base connection module non-public and making connection attribute non-public
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
Making base connection module non-public and making connection attribute non-public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have held off on renaming
google.cloud.${PACKAGE}.connectionto_httpfor the 5 packages in #2690, but I can do that in this PR if desired. The PR is already pretty large though.