Skip to content

Remove all TODOs from code #146

@dhermes

Description

@dhermes

A quick check gives:

$ grep -ir todo .
./tox.ini:# TODO: add py32,py33,py34
./gcloud/datastore/helpers.py:    # TODO(jjg): Should we raise a ValueError here?
./gcloud/datastore/key.py:  # TODO: Determine if this really should be immutable.
./gcloud/datastore/query.py:# TODO: Figure out how to properly handle namespaces.
./gcloud/datastore/query.py:    # TODO(jjg): Double check that this makes sense...
./gcloud/datastore/query.py:    # TODO: Do we want this to be additive?
./gcloud/datastore/connection.py:    # TODO: Is this the right method name?
./gcloud/datastore/connection.py:    # TODO: How do you delete properties? Set them to None?
./gcloud/datastore/connection.py:    # TODO: Make this return value be a True/False (or something more useful).
./gcloud/datastore/connection.py:    # TODO: Is this the right way to handle deleting
./gcloud/datastore/entity.py:    # TODO(jjg): Raise an error if something dumb happens.
./gcloud/datastore/entity.py:    # TODO: Make sure that this makes sense.
./gcloud/storage/iterator.py:  # TODO: Use an actual HTTP streaming library,
./gcloud/storage/key.py:    # TODO: If a bucket isn't defined, this is basically useless.
./gcloud/storage/key.py:    # TODO: Add good error checking.
./gcloud/storage/key.py:    # TODO: Add good exception handling.
./gcloud/storage/key.py:    # TODO: Set timestamp? Make optional, default being to set it if possible?
./gcloud/storage/key.py:      # TODO: Error checking for response code.
./gcloud/storage/key.py:      # TODO: Exponential backoff when errors come through.
./gcloud/storage/key.py:    # TODO: How do we handle NotFoundErrors?
./gcloud/storage/key.py:    # TODO: This might be a VERY long list. Use the specific API endpoint.
./gcloud/storage/bucket.py:    # TODO: Make sure the proper exceptions are raised.
./gcloud/storage/bucket.py:    # TODO: Should we accept a 'silent' param here to not raise an exception?
./gcloud/storage/bucket.py:    # TODO: What should be the return value here?
./gcloud/storage/bucket.py:    # TODO: What do we do about overwriting data?
./gcloud/storage/bucket.py:    # TODO: This might be a VERY long list. Use the specific API endpoint.
./gcloud/storage/connection.py:    # TODO: Add better error handling.
./gcloud/storage/connection.py:      # TODO: Better checking on this header for JSON.
./gcloud/storage/connection.py:    # TODO: URL-encode the bucket name to be safe?
./gcloud/storage/connection.py:    # TODO: Which exceptions will this raise?
./gcloud/storage/exceptions.py:# TODO: Make these super useful.
./gcloud/storage/__init__.py:# TODO: Allow specific scopes and authorization levels.
./gcloud/storage/acl.py:      # TODO: Add validation of types.

I will be removing all these from the code and filing a bug for each.

Metadata

Metadata

Assignees

Labels

🚨This issue needs some love.triage meI really want to be triaged.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions