Initial implementation of requester-pays feature for Storage #1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Completely untested so far. (Need to use two different projects...)
ae3d48d to
753bf13
Compare
chrisdunelm
approved these changes
May 30, 2017
| { | ||
| return; | ||
| } | ||
|
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
These require two extra environment variables (REQUESTER_PAYS_TEST_PROJECT and REQUESTER_PAYS_CREDENTIALS) to be set. If they aren't set, requester-pays testing is not performed. Note that within the fixture code, we have to specify the UserProject option for all operations - I don't *think* we should have to do that, but it looks like it's required right now.
google-cloud-sdk-librarian-dotnet-robot
added a commit
that referenced
this pull request
Aug 8, 2025
feat: Update Compute Engine v1 API to revision 20250729 (#1085) Source-Link: googleapis/googleapis@a386edb
jskeet
pushed a commit
that referenced
this pull request
Aug 8, 2025
feat: Update Compute Engine v1 API to revision 20250729 (#1085) Source-Link: googleapis/googleapis@a386edb
google-cloud-sdk-librarian-dotnet-robot
added a commit
that referenced
this pull request
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not as bad as it looks - the vast majority of this code is just repeated for each request.