chore(all): Drop submodule backreferences #1087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quartzmo
approved these changes
Feb 27, 2024
codyoss
approved these changes
Feb 27, 2024
|
@liggitt Can you resolve conflicts in your branch? Once it's up to date, we'll merge this PR. |
|
done |
auto-merge was automatically disabled
February 27, 2024 22:01
Head branch was pushed to by a user without write access
|
rebased on master after #1090 |
|
do you want me to rebase on master or leave this as-is? |
|
@liggitt Please rebase, thanks! |
|
done |
|
Opened #1093 to update the first set of submodules that reference just the ../rpc submodule |
|
(successful bump of the rpc and api deps in kubernetes in kubernetes/kubernetes#123569) |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening the PR to drop backreferences as the next step for #1015
Target for merging this is 2024-03-01.
After this is merged, we would ripple out
requireupdates for the submodules that pruned backreferences, all the way up to the root genproto module.cc @quartzmo