Fix possible warning in header #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like a reasonable workaround. |
|
What does "possible warning" mean? Is there some compiler/set of options you actually observed a warning with? This will all be deleted soon anyway, since absl now supports logging. |
Yes, gcc 11.2 with some flags, warnings about unused variable. But I think it can be avoided if we interprete s2 headers like system headers.
Good we don't really use it. |
|
https://github.com/arangodb/arangodb/blob/devel/3rdParty/README_maintainers.md#s2geometry We have patch, and mostly it fix warnings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if no defined ABSL_MIN_LOG_LEVEL severity_ will be unused.
Because its header it's pretty inconvenient.
As an alternative solution will be make field under ifdef.
But in this case layout of class will be changed, so I don't know, is it valid for you, I decide to make more simple fix.