Fix quoting of codepoints requiring surrogate pairs. #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8b4c92d to
1a41124
Compare
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
==========================================
+ Coverage 89.06% 89.27% +0.20%
==========================================
Files 18 18
Lines 3019 3022 +3
Branches 607 607
==========================================
+ Hits 2689 2698 +9
+ Misses 192 186 -6
Partials 138 138
Continue to review full report at Codecov.
|
1a41124 to
a432619
Compare
Previously, the parser would match each individual character within a
\Q...\E section. Runes requiring a surrogate pair would be incorrectly
treated as two individual characters.
E.g.
String source = new StringBuilder().appendCodePoint(110781).toString();
Before this change:
Parser.parse(source, ...) matches \x{1b0bd}
Parser.parse("\\Q" + source + "\\E", ...) matches \x{d82c}\x{dcbd}
After this change:
Parser.parse(source, ...) matches \x{1b0bd}
Parser.parse("\\Q" + source + "\\E", ...) matches \x{1b0bd}
Fixes google#123.
ed25d21 to
1012489
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the parser would match each individual character within a
\Q...\E section. Runes requiring a surrogate pair would be incorrectly
treated as two individual characters.
E.g.
String source = new StringBuilder().appendCodePoint(110781).toString();
Before this change:
Parser.parse(source, ...) matches \x{1b0bd}
Parser.parse("\Q" + source + "\E", ...) matches \x{d82c}\x{dcbd}
After this change:
Parser.parse(source, ...) matches \x{1b0bd}
Parser.parse("\Q" + source + "\E", ...) matches \x{1b0bd}
Fixes #123.