Make the process<Configuration>GoogleServices tasks config avoidant #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://docs.gradle.org/current/userguide/task_configuration_avoidance.html This does have the unfortunate side effect of the plugin not complaining about a missing `google-services.json` unless some `process<Configuration>GoogleServices` task gets run somehow. However, that may be better for local development where the answer of how to get a relevant `google-services.json` can be postponed until after it builds at all. (Though I understand AndroidStudio is capable of handling `google-services.json`, it would still be good for those forced to use CLI development only). Fixes: google#180
davidmotson
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the processGoogleServices tasks config avoidant
See https://docs.gradle.org/current/userguide/task_configuration_avoidance.html
This does have the unfortunate side effect of the plugin not complaining about a missing
google-services.jsonunless someprocess<Configuration>GoogleServicestask gets run somehow.However, that may be better for local development where the answer of how to get a relevant
google-services.jsoncan be postponed until after it builds at all. (Though I understand AndroidStudio is capable of handlinggoogle-services.json, it would still be good for those forced to use CLI development only).TESTED: Verified by a really simple local android project. Without this change, it complained about
google-services.jsonimmediately. With this change, it only complained about it if:processReleaseGoogleServicesor:processDebugGoogleServiceswas run (directly or indirectly)Fixes: #180