Demonstrate file::GetContents / SetContents memory leak #4009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazel build //ortools/base:hello_file ./bazel-bin/ortools/base/hello_file valgrind --leak-check=full ./bazel-bin/ortools/base/hello_file &> leak.out bazel build --cxxopt=-DFIX_MEMORY_LEAK //ortools/base:hello_file ./bazel-bin/ortools/base/hello_file valgrind --leak-check=full ./bazel-bin/ortools/base/hello_file &> no-leak.out
0318013 to
df579a7
Compare
This was referenced Dec 2, 2023
|
Since this issue has been solved by I think it's safe to close this ticket. Personal opinion: returning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce the memory leak cherry-pick this PR, ensure you have
valgrindinstalled and then:Here's the output I see: leak.out, no-leak.out
valgrind reports "definitely lost: 48 bytes in 2 blocks" for or-tools at head, but "definitely lost: 0 bytes in 0 blocks" when the File is deleted after closing it.