fix: prevent panic when batchResp is nil in MatchVulnerabilities #1922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add nil check for batchResp before accessing Results to avoid panic * Handle timeout scenarios gracefully by returning error instead of crashing * Add test case to verify timeout behavior with deadline exceeded error * Add function documentation comment for MatchVulnerabilities method
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
another-rex
approved these changes
Jun 4, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1922 +/- ##
==========================================
+ Coverage 65.67% 65.69% +0.02%
==========================================
Files 166 166
Lines 16064 16058 -6
==========================================
Hits 10550 10550
+ Misses 4848 4842 -6
Partials 666 666 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cuixq
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
MatchVulnerabilitiesmethod inosvmatcher.gocould panic when accessingbatchResp.ResultsifbatchRespis nil.Solution
batchRespbefore accessing itsResultsfieldTesting
"Timeout returns deadline exceeded error"to verify the timeout behaviorcontext.DeadlineExceedederror without panickingChanges
internal/clients/clientimpl/osvmatcher/osvmatcher.go: Added nil check and documentationinternal/clients/clientimpl/osvmatcher/osvmatcher_test.go: New test file with timeout test case