test: remove redundant os.Exit calls
#1772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1772 +/- ##
=======================================
Coverage 65.02% 65.02%
=======================================
Files 163 163
Lines 15941 15941
=======================================
Hits 10365 10365
Misses 4897 4897
Partials 679 679 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
another-rex
approved these changes
Apr 1, 2025
hogo6002
approved these changes
Apr 1, 2025
another-rex
pushed a commit
that referenced
this pull request
May 27, 2025
) We've already addressed the violations of this in #1772, but could not enable the rule at the time as it was mistakenly omitted from the schema used by the action to valid the linter config - now though golangci/golangci-lint#5692 has been released and we've upgraded, that is no longer an issue 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently since Go v1.15
os.Exitwill be called automatically by the runner with the result ofm.Runif a call to exit has not been made whenTestMainfinishes, so we can omit doing it ourselves