-
Notifications
You must be signed in to change notification settings - Fork 2.5k
bitcoin-core: temporarily disable IPC build #13854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sjors is a new contributor to projects/bitcoin-core. The PR must be approved by known contributors before it can be merged. The past contributors are: fanquake, hebasto, maflcko, marcofleon, guidovranken |
Marked draft pending feedback for other Bitcoin Core contributors. |
Switched to using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Makes sense to temporarily disable to get a green build again. Another workaround or fix can be done in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This is fine to merge after a passing CI
bitcoin/bitcoin#31802 builds libmultiprocess and enables IPC by default, but my understanding is that this breaks oss-fuzz. One proposed solution is #13018.
This PR builds depends with
NO_IPC=1
, which disables the feature, for now while we work on an actual fix.