Skip to content

Conversation

maflcko
Copy link
Contributor

@maflcko maflcko commented Nov 25, 2024

Fixes https://issues.oss-fuzz.com/issues/380676570

Excerpt:

Step #1: Step 5/13 : RUN git clone --depth 1 https://github.com/guidovranken/cryptofuzz
Step #1:  ---> Running in def8cd621b2d
Step #1: �[91mCloning into 'cryptofuzz'...
Step #1: �[0m�[91mfatal: could not read Username for 'https://github.com': No such device or address
Step #1: The command '/bin/sh -c git clone --depth 1 https://github.com/guidovranken/cryptofuzz' returned a non-zero code: 128
Finished Step #1
ERROR

This is a clean removal, which can be reverted in the future, or reworked.

For now, go ahead with the removal, to unbreak the build.

@maflcko maflcko changed the title bitcoin-core: Fix build after project removal bitcoin-core: Fix build after cryptofuzz removal Nov 25, 2024
Copy link

maflcko has previously contributed to projects/bitcoin-core. The previous PR was #12452

@DavidKorczynski DavidKorczynski merged commit 61d8ee2 into google:master Nov 25, 2024
16 checks passed
@maflcko maflcko deleted the 2411-fix-bld branch November 25, 2024 09:42
@maflcko
Copy link
Contributor Author

maflcko commented Dec 5, 2024

cc secp256k1 people (@real-or-random @jonasnick @sipa), just letting you know about the removal. Not sure what (and if) something should be done as a follow-up.

@real-or-random
Copy link

At least we still have the code: Up-to-date forks of https://github.com/guidovranken/cryptofuzz (and the submodule https://github.com/guidovranken/cryptofuzz-corpora) are still available under https://github.com/MozillaSecurity/cryptofuzz and https://github.com/KurSh/cryptofuzz-corpora [1]. And just to make sure, I forked these two and all other public repos under the guidovranken account to my account...

But sure, the code alone does not solve the problem. If we want to keep fuzzing, we'll need someone who maintains cryptofuzz, at least in the medium term. And I have no idea how to make that work. I wonder if the other affected maintainers have any plans. There are some big names in #12746 (comment), e.g., LibreSSL and Django.

[1] Found those via GitHub search: https://github.com/search?q=%22cryptofuzz%22++language%3AC%2B%2B+fork%3Atrue&type=repositories&ref=advsearch, https://github.com/search?q=%22cryptofuzz-corpora%22++language%3AC%2B%2B+fork%3Atrue&type=repositories&ref=advsearch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants