Skip to content

[envoy] disable layering_check from bazel build #12731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2024
Merged

[envoy] disable layering_check from bazel build #12731

merged 1 commit into from
Nov 18, 2024

Conversation

adisuissa
Copy link
Contributor

A recent upgrade of Envoy' abseil library (envoyproxy/envoy#36317) enabled layering_check (imported commit) when building abseil (as part of Envoy).

Here's an example of the failure during the build:

�[1A�[K�[31m�[1mERROR: �[0m/root/.cache/bazel/_bazel_root/4e9824db8e7d11820cfa25090ed4ed10/external/com_google_absl/absl/types/BUILD.bazel:178:11: Compiling absl/types/bad_variant_access.cc failed: undeclared inclusion(s) in rule '@com_google_absl//absl/types:bad_variant_access':
Step #3 - "compile-honggfuzz-address-x86_64": this rule is missing dependency declarations for the following files included by 'absl/types/bad_variant_access.cc':
Step #3 - "compile-honggfuzz-address-x86_64":   'bazel-out/k8-fastbuild-ST-74a21d80f561/bin/external/com_google_absl/absl/base/core_headers.cppmap'
Step #3 - "compile-honggfuzz-address-x86_64":   'bazel-out/k8-fastbuild-ST-74a21d80f561/bin/external/com_google_absl/absl/base/atomic_hook.cppmap'
Step #3 - "compile-honggfuzz-address-x86_64":   'bazel-out/k8-fastbuild-ST-74a21d80f561/bin/external/com_google_absl/absl/base/errno_saver.cppmap'
Step #3 - "compile-honggfuzz-address-x86_64":   'bazel-out/k8-fastbuild-ST-74a21d80f561/bin/external/com_google_absl/absl/base/log_severity.cppmap'

Seems that this was encountered in the OSS-Fuzz abseil build and it was patched to disable layering check #11325:

oss-fuzz/projects/abseil-cpp/build.sh

Lines 17 to 21 in f0fa8b5

# Disable `layering_check` feature.
# As per https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=63223, it breaks
# the build. Someone could figure out exactly why it breaks the build, but just
# disabling it suffices because it doesn't actually matter for our purposes. ;)
export BAZEL_EXTRA_BUILD_FLAGS='--features=-layering_check'

This PR introduces the same change in Envoy's abseil build.

@adisuissa
[envoy] disable layering_check from bazel build
565dd51 
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
@github-actions GitHub Actions
Copy link

adisuissa is either the primary contact or is in the CCs list of projects/envoy.
adisuissa has previously contributed to projects/envoy. The previous PR was #11980

jonathanmetzman
jonathanmetzman approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonathanmetzman jonathanmetzman enabled auto-merge (squash) November 18, 2024 17:10
@jonathanmetzman jonathanmetzman merged commit 11e3a93 into google:master Nov 18, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanmetzman jonathanmetzman jonathanmetzman approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adisuissa @jonathanmetzman