Skip to content

[connectedhomeip] Upgrade python version to 3.10 #12533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2024
Merged

[connectedhomeip] Upgrade python version to 3.10 #12533

merged 1 commit into from
Sep 25, 2024

Conversation

Alami-Amine
Copy link
Contributor

@Alami-Amine Alami-Amine commented Sep 24, 2024 •
edited
Loading

  • OSS-Fuzz builds are failing after pigweed was rebased in Update pigweed to the latest version project-chip/connectedhomeip#35644

  • One of the failures is related to pigweed becoming incompatible with python <3.9. Such as using subscript notation in the type hints.

  • Fix: Base images in OSS-Fuzz use python 3.8, This PR aims to force the usage of python3.10 instead

Example Error

Step #1: Traceback (most recent call last):
Step #1:   File "../../third_party/pigweed/repo/pw_build/py/pw_build/python_runner.py", line 38, in <module>
Step #1:     import gn_resolver  # type: ignore
Step #1:   File "/src/connectedhomeip/third_party/pigweed/repo/pw_build/py/pw_build/gn_resolver.py", line 319, in <module>
Step #1:     _Actions = Iterator[tuple[_ArgAction, str]]
Step #1: TypeError: 'type' object is not subscriptable
Step #1: [137/1234] ln -f ../../third_party/pigweed/repo/pw_thread/pw_thread_protos/thread_snapshot_service.proto

@github-actions GitHub Actions
Copy link

Alami-Amine has previously contributed to projects/connectedhomeip. The previous PR was #12484

@Alami-Amine Alami-Amine marked this pull request as ready for review September 24, 2024 23:02
@Alami-Amine Alami-Amine changed the title [connectedhomeip] Making python3.10 as default [connectedhomeip] Upgrade python version to 3.10 Sep 24, 2024
@Alami-Amine
Copy link
Contributor Author

@DavidKorczynski Could I get a review please?

@DavidKorczynski DavidKorczynski merged commit 9367a9c into google:master Sep 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidKorczynski DavidKorczynski DavidKorczynski approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alami-Amine @DavidKorczynski