Skip to content

[envoy] fix clang18 libclang_rt linkage issue #11980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2024
Merged

[envoy] fix clang18 libclang_rt linkage issue #11980

merged 2 commits into from
May 22, 2024

Conversation

adisuissa
Copy link
Contributor

Envoy's UBSAN build current fails with the following error:

�[1A�[K�[31m�[1mERROR: �[0m/src/envoy/test/common/router/BUILD:233:21: Linking test/common/router/config_impl_test_static failed: (Exit 1): clang-18 failed: error executing command (from target //test/common/router:config_impl_test_static) 
Step #23 - "compile-libfuzzer-undefined-x86_64":   (cd /root/.cache/bazel/_bazel_root/4e9824db8e7d11820cfa25090ed4ed10/execroot/envoy && \
Step #23 - "compile-libfuzzer-undefined-x86_64":   exec env - \
Step #23 - "compile-libfuzzer-undefined-x86_64":     BAZEL_COMPILER=clang \
Step #23 - "compile-libfuzzer-undefined-x86_64":     BAZEL_CXXOPTS='-stdlib=libc++' \
Step #23 - "compile-libfuzzer-undefined-x86_64":     BAZEL_LINKLIBS=-l%:libc++.a:-l%:libc++abi.a \
Step #23 - "compile-libfuzzer-undefined-x86_64":     BAZEL_LINKOPTS=-lm:-pthread \
Step #23 - "compile-libfuzzer-undefined-x86_64":     CC=clang \
Step #23 - "compile-libfuzzer-undefined-x86_64":     CXX=clang++ \
Step #23 - "compile-libfuzzer-undefined-x86_64":     CXXFLAGS='-stdlib=libc++' \
Step #23 - "compile-libfuzzer-undefined-x86_64":     FUZZINTRO_OUTDIR=/src \
Step #23 - "compile-libfuzzer-undefined-x86_64":     LDFLAGS='-stdlib=libc++' \
Step #23 - "compile-libfuzzer-undefined-x86_64":     PATH=/bin:/usr/bin:/usr/local/bin \
Step #23 - "compile-libfuzzer-undefined-x86_64":     PWD=/proc/self/cwd \
Step #23 - "compile-libfuzzer-undefined-x86_64":   /usr/local/bin/clang-18 @bazel-out/k8-fastbuild-ST-0a6de8256f3b/bin/test/common/router/config_impl_test_static-2.params)
Step #23 - "compile-libfuzzer-undefined-x86_64": # Configuration: bcd0434cd1f68317f811560892076634a5706878d94e6459b56108eb78a3a66e
Step #23 - "compile-libfuzzer-undefined-x86_64": # Execution platform: @local_config_platform//:host
Step #23 - "compile-libfuzzer-undefined-x86_64": ld.lld: error: undefined symbol: __ubsan_vptr_type_cache
Step #23 - "compile-libfuzzer-undefined-x86_64": >>> referenced by socket_interface.h:69 (./envoy/network/socket_interface.h:69)
Step #23 - "compile-libfuzzer-undefined-x86_64": >>>               bazel-out/k8-fastbuild-ST-0a6de8256f3b/bin/test/common/router/_objs/config_impl_test_lib/config_impl_test.pic.o:(Envoy::Network::ioHandleForAddr(Envoy::Network::Socket::Type, std::__1::shared_ptr<Envoy::Network::Address::Instance const>, Envoy::Network::SocketCreationOptions const&))
Step #23 - "compile-libfuzzer-undefined-x86_64": >>> referenced by shared_ptr.h:772 (/usr/local/bin/../include/c++/v1/__memory/shared_ptr.h:772)
Step #23 - "compile-libfuzzer-undefined-x86_64": >>>               bazel-out/k8-fastbuild-ST-0a6de8256f3b/bin/test/common/router/_objs/config_impl_test_lib/config_impl_test.pic.o:(Envoy::Network::ioHandleForAddr(Envoy::Network::Socket::Type, std::__1::shared_ptr<Envoy::Network::Address::Instance const>, Envoy::Network::SocketCreationOptions const&))
Step #23 - "compile-libfuzzer-undefined-x86_64": >>> referenced by gtest-internal.h:532 (external/com_google_googletest/googletest/include/gtest/internal/gtest-internal.h:532)
Step #23 - "compile-libfuzzer-undefined-x86_64": >>>               bazel-out/k8-fastbuild-ST-0a6de8256f3b/bin/test/common/router/_objs/config_impl_test_lib/config_impl_test.pic.o:(testing::internal::SuiteApiResolver<Envoy::Router::(anonymous namespace)::RouteMatcherTest>::GetSetUpCaseOrSuite(char const*, int))
Step #23 - "compile-libfuzzer-undefined-x86_64": >>> referenced 174998 more times
Step #23 - "compile-libfuzzer-undefined-x86_64": 
Step #23 - "compile-libfuzzer-undefined-x86_64": ld.lld: error: undefined symbol: __ubsan_handle_dynamic_type_cache_miss_abort
Step #23 - "compile-libfuzzer-undefined-x86_64": >>> referenced by socket_interface.h:69 (./envoy/network/socket_interface.h:69)
Step #23 - "compile-libfuzzer-undefined-x86_64": >>>               bazel-out/k8-fastbuild-ST-0a6de8256f3b/bin/test/common/router/_objs/config_impl_test_lib/config_impl_test.pic.o:(Envoy::Network::ioHandleForAddr(Envoy::Network::Socket::Type, std::__1::shared_ptr<Envoy::Network::Address::Instance const>, Envoy::Network::SocketCreationOptions const&))
Step #23 - "compile-libfuzzer-undefined-x86_64": >>> referenced by socket_interface.h:69 (./envoy/network/socket_interface.h:69)
Step #23 - "compile-libfuzzer-undefined-x86_64": >>>               bazel-out/k8-fastbuild-ST-0a6de8256f3b/bin/test/common/router/_objs/config_impl_test_lib/config_impl_test.pic.o:(Envoy::Network::ioHandleForAddr(Envoy::Network::Socket::Type, std::__1::shared_ptr<Envoy::Network::Address::Instance const>, Envoy::Network::SocketCreationOptions const&))
Step #23 - "compile-libfuzzer-undefined-x86_64": >>> referenced by shared_ptr.h:772 (/usr/local/bin/../include/c++/v1/__memory/shared_ptr.h:772)
Step #23 - "compile-libfuzzer-undefined-x86_64": >>>               bazel-out/k8-fastbuild-ST-0a6de8256f3b/bin/test/common/router/_objs/config_impl_test_lib/config_impl_test.pic.o:(Envoy::Network::ioHandleForAddr(Envoy::Network::Socket::Type, std::__1::shared_ptr<Envoy::Network::Address::Instance const>, Envoy::Network::SocketCreationOptions const&))
Step #23 - "compile-libfuzzer-undefined-x86_64": >>> referenced 244906 more times

Further debugging revealed that the upgrade to clang18 caused the breakage, due to different libclang_rt library file name. This PR fixes this issue.

@adisuissa
[envoy] fix clang18 libclang_rt linkage issue
4ace520 
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
@github-actions GitHub Actions
Copy link

adisuissa is either the primary contact or is in the CCs list of projects/envoy.
adisuissa has previously contributed to projects/envoy. The previous PR was #11921

kleisauke
kleisauke reviewed May 21, 2024
View reviewed changes
@kleisauke
Copy link
Contributor

Looks like other projects need something similar too:
https://github.com/search?q=repo%3Agoogle%2Foss-fuzz%20libclang_rt.ubsan_standalone_cxx&type=code

@adisuissa
Copy link
Contributor Author

Looks like other projects need something similar too: https://github.com/search?q=repo%3Agoogle%2Foss-fuzz%20libclang_rt.ubsan_standalone_cxx&type=code

When I looked at the build logs of some of these projects, it seemed that something else was broken.

@adisuissa
comments
0532191 
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
@DavidKorczynski DavidKorczynski merged commit 23db075 into google:master May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidKorczynski DavidKorczynski DavidKorczynski approved these changes

+1 more reviewer

@kleisauke kleisauke kleisauke left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adisuissa @kleisauke @DavidKorczynski