bitcoin: remove --enable-lto usage
#11498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is going to be removed upstream. bitcoin/bitcoin#29185.
|
fanquake (verified) is either the primary contact or is in the CCs list of projects/bitcoin-core. |
DavidKorczynski
approved these changes
Jan 16, 2024
hebasto
reviewed
Jan 16, 2024
| # "/usr/bin/ld: error: Failed to link module lib/libevent.a.llvm.17822.buffer.c: Expected at most one ThinLTO module per bitcode file". | ||
| # export CFLAGS="$CFLAGS -flto=thin" | ||
| export CXXFLAGS="$CXXFLAGS -flto=thin" | ||
| export LDFLAGS="-flto=thin" |
There was a problem hiding this comment.
I'm still not sure that setting LDFLAGS is needed at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is going to be removed upstream: bitcoin/bitcoin#29185.
Skip
CFLAGSfor now. It looks like previously this was not getting properly applied, but would now run into a (fixed in later versions) LLVM bug.Set
NM&STRIPtollvm-*so we are consistently using LLVM tools.