-
Notifications
You must be signed in to change notification settings - Fork 2.5k
ron: support upstream changes #10649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ron: support upstream changes #10649
Conversation
manunio has previously contributed to projects/ron. The previous PR was #8676 |
@manunio I thought I had fixed the unknown feature bug already by removing the Cargo.lock file from the fuzzer, which had pinned an old version of proc-macro2. |
Hi, I'm not sure why but it was still failing at my local machine even after applying your fix. Let me check that against ci. |
@juntyr checked it against ci its failing.
|
Oh dang that’s my fault, sorry. The PR branch wasn’t rebased yet - let me fix that quickly |
Ok, let’s see if CI works now. If it does, I’ll merge the PR into ron and we can change this PR to just point at the ron head again. |
@juntyr ci is passing now. |
Thank you so much for your help! I've merged the PR into ron. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Pins rust version for Add a fuzzer test that serialises and deserialises arbitrary typed serde data + fix&[u8]
de ron-rs/ron#462 (Build was failing locally withunknown feature proc_macro_span_shrink
error)cc @juntyr