Skip to content

Test setValue(null) (both success and failure cases) #3176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Test setValue(null) (both success and failure cases) #3176

wants to merge 4 commits into from

Conversation

nikhilbarar
Copy link
Contributor

Added tests:

  • entry.setValue(null)

@nikhilbarar
Added tests:
1b05b36 
- entry.setValue(null)
@nikhilbarar nikhilbarar mentioned this pull request Jun 7, 2018
Closed
@kluever kluever requested a review from cpovirk June 11, 2018 02:32
@cpovirk
Copy link
Member

cpovirk commented Jun 12, 2018

Can you suppress the new methods in

guava/guava-testlib/src/com/google/common/collect/testing/TestsForMapsInJavaUtil.java

Line 156 in c2f8967

return asList(MapEntrySetTester.getSetValueMethod());
?

I'm interested to see if that fixes all the failures.

@nikhilbarar
google#2467: Suppressed Tests (SetValueWithNullValuesAbsent, SetValue…
bd1ee68 
…WithNullValuesPresent) for ConcurrentSkipListMap
@nikhilbarar
google#2467: Suppressed Tests (SetValueWithNullValuesAbsent, SetValue…
ebb8806 
…WithNullValuesPresent) for ForwardingNavigableMap
@nikhilbarar
Copy link
Contributor Author

Thanks. setValue method was already present in the suppress list of ConcurrentSkipListMap and ForwardingNavigableMap tests.

I've added the new methods as well at both the locations, which fixed all the failures.

@cpovirk
Copy link
Member

cpovirk commented Jun 13, 2018

Thanks very much. I've submitted this internally. It will be mirrored out within the next few days, with you listed as the author.

@nikhilbarar
Copy link
Contributor Author

Thanks 👍 Happy to help

cgdecker pushed a commit that referenced this pull request Jun 28, 2018
@nikhilbarar @cgdecker
Test setValue(null) (both success and failure cases).
ac1549b 
Fixes #2467, #3176

RELNOTES=n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=200386576
cgdecker pushed a commit that referenced this pull request Jun 28, 2018
@nikhilbarar @cgdecker
Test setValue(null) (both success and failure cases).
438d6d9 
Fixes #2467, #3176

RELNOTES=n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=200386576
@WilliamCollishaw
Copy link
Contributor

Looks like this PR can be closed, all changes are available in master. See #3191

@cgdecker cgdecker closed this May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpovirk cpovirk Awaiting requested review from cpovirk

Assignees

@cpovirk cpovirk

Labels
cla: yes package=testing status=triaged type=addition A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nikhilbarar @cpovirk @WilliamCollishaw @cgdecker @kluever @googlebot