feat: no floating promises #756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33256b9 to
94deaee
Compare
|
someone please take a look please |
|
@naseemkullah - I'll discuss this with the team and get back to you |
|
Hey @naseemkullah, the PR looks great - thanks for the contribution. To not immediately break anyone do you mind changing the rule to |
|
Thanks @danielbankhead - certainly, changed to |
closes google#546 Signed-off-by: Naseem Ullah <24660299+naseemkullah@users.noreply.github.com>
danielbankhead
approved these changes
Sep 11, 2023
danielbankhead
added a commit
that referenced
this pull request
Oct 3, 2023
This reverts commit c93e733.
danielbankhead
added a commit
that referenced
this pull request
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #546