Skip to content

fix: ParseBenchmark json property typo #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2023
Merged

fix: ParseBenchmark json property typo #2473

merged 1 commit into from
Aug 19, 2023

Conversation

0o001
Copy link
Contributor

@0o001 0o001 commented Aug 19, 2023 •
edited
Loading

Purpose

Description

Checklist

  • New code follows the Google Java Style Guide
  • If necessary, new public API validates arguments, for example rejects null
  • New public API has Javadoc
    • Javadoc uses @since $next-version$
      ($next-version$ is a special placeholder which is automatically replaced during release)
  • If necessary, new unit tests have been added
    • Assertions in unit tests use Truth, see existing tests
    • No JUnit 3 features are used (such as extending class TestCase)
    • If this pull request fixes a bug, a new test was added for a situation which failed previously and is now fixed
  • mvn clean verify javadoc:jar passes without errors

Marcono1234
Marcono1234 approved these changes Aug 19, 2023
View reviewed changes
Copy link
Contributor

@Marcono1234 Marcono1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This fix seems correct; the field has indeed the name default... in /metrics/src/main/resources/ParseBenchmarkData.zip/TWEETS.json.

@eamonnmcmanus eamonnmcmanus merged commit 1e7625b into google:main Aug 19, 2023
tibor-universe pushed a commit to getuniverse/gson that referenced this pull request Sep 14, 2024
@0o001 @tibor-universe
fix: ParseBenchmark json property typo (google#2473)
c9dc5ef
DanySK pushed a commit to DanySK/gson-extras that referenced this pull request Jan 30, 2025
@semantic-release-bot
chore(release): 3.0.0 [skip ci]
245da79 
## [3.0.0](2.0.0...3.0.0) (2025-01-30)

### ⚠ BREAKING CHANGES

* Merge remote-tracking branch 'google/main'

### Dependency updates

* **api-deps:** update dependency com.google.code.gson:gson to v2.12.0 ([#802](#802)) ([e85a651](e85a651))

### Bug Fixes

* ParseBenchmark json property typo ([google#2473](https://github.com/DanySK/gson-extras/issues/2473)) ([1e7625b](1e7625b))

### Revert previous changes

* Revert "Bump org.codehaus.plexus:plexus-utils from 3.5.1 to 4.0.0 ([google#2468](https://github.com/DanySK/gson-extras/issues/2468))" ([google#2469](https://github.com/DanySK/gson-extras/issues/2469)) ([db4a58a](db4a58a))

### Build and continuous integration

* harden build.yml permissions ([google#2274](https://github.com/DanySK/gson-extras/issues/2274)) ([c33e03b](c33e03b))
* track the Gradle wrapper `distributionSha256Sum` ([c3b208d](c3b208d))

### General maintenance

* Merge remote-tracking branch 'google/main' ([8abc8fa](8abc8fa))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamonnmcmanus eamonnmcmanus eamonnmcmanus approved these changes

+1 more reviewer

@Marcono1234 Marcono1234 Marcono1234 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0o001 @eamonnmcmanus @Marcono1234