Add test for unused class to shrinker-test #2455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eamonnmcmanus
approved these changes
Jul 29, 2023
|
@eamonnmcmanus, just to avoid any confusion, this does not address the open points I mentioned in #2448 regarding updating comments and adding a separate test for a class without no-args constructor. This here adds a different test case, and I simply decided to base it on #2448 to reduce merge conflicts later. |
3abbfcf to
479ceb9
Compare
|
Thanks, still looks good! |
tibor-universe
pushed a commit
to getuniverse/gson
that referenced
this pull request
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Extends tests of
shrinker-testfor unused classesDescription
Based on #2448
Adds a test case for a class with a field annotated with
@SerializedName, but which is not actually used anywhere. The default Gson ProGuard rules should allow this class to be removed.Note: This actually works as intended for R8, but not for ProGuard which keeps the class. Not sure if it is worth investigating that further at the moment.
Checklist
null@since $next-version$(
$next-version$is a special placeholder which is automatically replaced during release)TestCase)mvn clean verify javadoc:jarpasses without errors