Mention in User Guide alternative for Gson versions without fromJson(..., TypeToken) #2209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great idea! In general people might be reading the current user guide online but working with an older Gson version for whatever reason. While we don't want to make the guide unreadable with notes here and there about how things used to work, occasional comments like this in key places are worthwhile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #1700
Inspired by #2208; the changes done by #1700 to the User Guide will be confusing for users who are not using the latest Gson version (especially since those changes have not been released yet). This pull request tries to adjust the User Guide to make this clearer. Feedback is appreciated!