Fix gradle build #1820
Fix gradle build #1820
Conversation
| it.inputs.property("gsonversion", version) | ||
| it.from(layout.projectDirectory.dir("src/main/java-gradle-templates/com/google/gson/internal")) | ||
| it.into(project.layout.buildDirectory.dir("generated/sources/version-templates/java/main/com/google/gson/internal")) | ||
| it.expand(["gsonversion": version]) |
There was a problem hiding this comment.
Would it be possible to change this to:
| it.expand(["gsonversion": version]) | |
| it.expand(["{project.version}": version]) |
and then re-use the existing Maven template class? This is a little bit hacky, but might be less error-prone than having two separate source files for this.
Alternatively could you please modify https://github.com/google/gson/blob/master/gson/src/test/java/com/google/gson/internal/GsonBuildConfigTest.java to verify that the version is not $gsonversion either (or in general does not start with $; that would probably be most reliable)?
Note that I am not a member of this project.
There was a problem hiding this comment.
No templates in gradle copies have a different template mechanism. I tried some basic escaping of the dot but without much luck
There was a problem hiding this comment.
Do you think it would make sense to use Copy.filter(Closure) instead? And then manually replace ${project.version} in the lines?
And regardless of whether you decide to do this, could you please adjust the GsonBuildConfigTest.java to check for a leading $ (instead of "${project.version}"), maybe also with a comment to explain the rationale, so the test becomes more robust?
Not sure if this is maintained, but this at least updates the gradle version and fixes the project version injection