Skip to content

feat: Add support for sub-issue #3580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
May 26, 2025
Merged

feat: Add support for sub-issue #3580

merged 17 commits into from
May 26, 2025

Conversation

e7217
Copy link
Contributor

@e7217 e7217 commented May 20, 2025 •
edited
Loading

Hello,
I have added some features to support Sub-issue.

The following features have been added:

  • Add sub-issue
  • Remove sub-issue
  • Get sub-issue list by issue
  • Reprioritize sub-issue

Sorry for the delay in developing this feature.
Thank you for your review😀

Fixes #3546
cc @gmlewis

@codecov Codecov
Copy link

codecov bot commented May 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (304d3d0) to head (fde3e4b).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3580      +/-   ##
==========================================
+ Coverage   91.29%   91.32%   +0.03%     
==========================================
  Files         183      184       +1     
  Lines       16087    16143      +56     
==========================================
+ Hits        14686    14742      +56     
  Misses       1227     1227              
  Partials      174      174

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis
Copy link
Contributor

gmlewis commented May 20, 2025

Thank you, @e7217! Please follow the instructions in step 4 of CONTRIBUTING.md and push the changes to this PR.

gmlewis
gmlewis suggested changes May 20, 2025
View reviewed changes
Copy link
Contributor

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @e7217!
This was a quick review because that's all I currently have time for, but should help move this PR in the right direction.

e7217 and others added 9 commits May 21, 2025 01:59
@e7217 @gmlewis
Update github/sub_issue.go
7c48809 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@e7217 @gmlewis
Update github/sub_issue.go
5562069 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@e7217 @gmlewis
Update github/sub_issue.go
42e1772 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@e7217 @gmlewis
Update github/sub_issue.go
8c3d97c 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@e7217 @gmlewis
Update github/sub_issue.go
36a4697 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@e7217 @gmlewis
Update github/sub_issue.go
c090164 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@e7217 @gmlewis
Update github/sub_issue.go
4b795b0 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@e7217 @gmlewis
Update github/sub_issue_test.go
b04e778 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@e7217
fix: update test case
42c6b67
@e7217
Copy link
Contributor Author

e7217 commented May 20, 2025

Thank you, @e7217! This was a quick review because that's all I currently have time for, but should help move this PR in the right direction.

@gmlewis I appreciate your review. It has been helpful to me.

gmlewis
gmlewis suggested changes May 20, 2025
View reviewed changes
Copy link
Contributor

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @e7217!
Just a few more tweaks, and a few comments that were not addressed previously, please... then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label May 20, 2025
e7217 and others added 2 commits May 21, 2025 08:49
@e7217 @gmlewis
Apply suggestions from code review
7d03490 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@e7217
fix: update test cases
d977c43
@e7217
Copy link
Contributor Author

e7217 commented May 21, 2025

@gmlewis
Oh, it was my mistake. I'm sorry for the inconvenience. Despite that, thank you for your detailed review. I have made a commit that includes your checking points and updated the test cases.

gmlewis
gmlewis suggested changes May 21, 2025
View reviewed changes
github/sub_issue.go Outdated
Comment on lines 60 to 61
// TODO: remove custom Accept header when this API fully launches.
req.Header.Set("Accept", mediaTypeV3)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the documentation for these endpoints, I'm not seeing any need to add the mediaTypeV3 header, so all these lines can safely be removed, I believe. Feel free to correct me if I've missed them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the documentation for these endpoints, I'm not seeing any need to add the mediaTypeV3 header, so all these lines can safely be removed, I believe. Feel free to correct me if I've missed them.

The header values are included as shown below, and I used the predefined header values from go-github. Since the response was coming back correctly, I applied them as is. If you think it would be better to remove this, I will delete that part. Please let me know your opinion.
image

@gmlewis

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but the one you added doesn't match.

You added application/vnd.github.v3+json, so I think this one can be removed.

Copy link
Contributor Author

@e7217 e7217 May 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmlewis ok, I have removed it. Thank you!

gmlewis
gmlewis approved these changes May 21, 2025
View reviewed changes
Copy link
Contributor

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @e7217!
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@stevehipwell - might you have time for a code review? Thank you!

DiegoDev2
DiegoDev2 approved these changes May 26, 2025
View reviewed changes
Copy link
Contributor

@DiegoDev2 DiegoDev2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @e7217 @gmlewis

@gmlewis
Copy link
Contributor

gmlewis commented May 26, 2025

Thank you, @DiegoDev2!
Merging.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label May 26, 2025
@gmlewis gmlewis merged commit cc0e642 into google:master May 26, 2025
7 checks passed
@e7217 e7217 deleted the feat/add-subissue branch May 27, 2025 05:05
@martinnormark martinnormark mentioned this pull request Jun 3, 2025
Merged
@gmlewis gmlewis mentioned this pull request Jun 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@gmlewis gmlewis gmlewis approved these changes

@DiegoDev2 DiegoDev2 DiegoDev2 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Sub-Issue endpoints
3 participants
@e7217 @gmlewis @DiegoDev2