Skip to content

Add the URL, UpdateAt, and WorkflowRun fields to Artifacts #2660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2023
Merged

Add the URL, UpdateAt, and WorkflowRun fields to Artifacts #2660

merged 1 commit into from
Feb 6, 2023

Conversation

bryancallahan
Copy link
Contributor

gmlewis
gmlewis approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bryancallahan !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Feb 6, 2023
valbeat
valbeat approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@valbeat valbeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Feb 6, 2023
@gmlewis
Copy link
Contributor

gmlewis commented Feb 6, 2023

Thank you, @valbeat !
Merging.

@gmlewis gmlewis merged commit c855eb5 into google:master Feb 6, 2023
@bryancallahan
Copy link
Contributor Author

Thanks for the quick review all! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@valbeat valbeat valbeat approved these changes

@gmlewis gmlewis gmlewis approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryancallahan @gmlewis @valbeat