Skip to content

ListOptions missing from GetAllOrganizationRulesets, Repositories.GetAllRulesets, Repositories.GetRulesForBranch functions #3560

@ktruedat

Description

@ktruedat

According to the Github API documentation for this endpoint (https://docs.github.com/en/rest/orgs/rules?apiVersion=2022-11-28#get-all-organization-repository-rulesets), there are pagination params needed to be able to fetch all the organization rulesets. However, the GetAllOrganizationRulesets doesn't have a ListOptions parameter that can be passed to the function and respectively to Github API for handling the pagination params. By default this API endpoint supports a 30 Per Page items with the default page being 1. Having no way to specify this params in the GetAllOrganizationRulesets will result in getting only the first 30 rulesets for the organization.

The same issue applies for Repositories.GetAllRulesets, Repositories.GetRulesForBranch functions, having no way to specify the pagination params

Metadata

Metadata

Assignees

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).enhancementgood first issue

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions