Skip to content

aws: disable rate limits by default with AWS #3496

@stanhu

Description

@stanhu

Describe the bug

After upgrading to go-cloud v0.39.0, one of our users reported:

operation error S3: PutObject, failed to get rate limit token, retry quota exceeded, 0 available, 5 requested

Terraform also has more details in hashicorp/terraform-provider-aws#36024 (comment). It seems the AWS team discussed this specific issue in aws/aws-sdk-go-v2#1665 (comment).

The bottom line is that SDK v2 adds new client rate limits, and users may hit this after switching from SDK v1. I recommend disabling these rate limits by default (as done in https://github.com/hashicorp/aws-sdk-go-base/pull/977/files) and provide a way to configure them if desired.

To Reproduce

I haven't tried this yet, but I imagine if you make lots of PutObject requests in quick succession you will hit these client rate limits.

Expected behavior

No rate limit errors.

Version

Which version(s) of the Go Cloud modules are you seeing the bug with?

v0.39.0

Additional context

Add any other context about the problem here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions